Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow to pass options for custom server #4110

Merged
merged 1 commit into from Dec 15, 2021
Merged

Conversation

snitin315
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Yes

Motivation / Use-Case

We already allow server: "own-server-package", so update schema to allow server: { type: "own-server-package" }

Breaking Changes

None

Additional Info

No

@alexander-akait
Copy link
Member

Will be great if we will try to integrate fastily and pure http module there, just in tests and if it will be ok, provide examples, because we should move out from express

@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #4110 (4049387) into master (69202d9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4110   +/-   ##
=======================================
  Coverage   92.77%   92.77%           
=======================================
  Files          14       14           
  Lines        1481     1481           
  Branches      547      547           
=======================================
  Hits         1374     1374           
  Misses         99       99           
  Partials        8        8           
Impacted Files Coverage Δ
bin/cli-flags.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 785cdeb...4049387. Read the comment docs.

@snitin315
Copy link
Member Author

Will be great if we will try to integrate fastily and pure http module there, just in tests and if it will be ok, provide examples, because we should move out from express

Yes, putting it in my TODO.

@snitin315 snitin315 merged commit fc8bed9 into master Dec 15, 2021
@snitin315 snitin315 deleted the fix/server-schema branch December 15, 2021 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants