Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show deprecation warning for cacert option #4115

Merged
merged 1 commit into from Dec 16, 2021

Conversation

snitin315
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Yes

Motivation / Use-Case

show deprecation warning for cacert option

Breaking Changes

None

Additional Info

No

@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #4115 (0f74aa2) into master (d3858cb) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4115      +/-   ##
==========================================
+ Coverage   92.64%   92.78%   +0.14%     
==========================================
  Files          14       14              
  Lines        1481     1484       +3     
  Branches      547      548       +1     
==========================================
+ Hits         1372     1377       +5     
+ Misses        101       99       -2     
  Partials        8        8              
Impacted Files Coverage Δ
lib/Server.js 94.04% <100.00%> (+0.01%) ⬆️
lib/servers/WebsocketServer.js 97.14% <0.00%> (+5.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3858cb...0f74aa2. Read the comment docs.

@alexander-akait alexander-akait merged commit c73ddfb into master Dec 16, 2021
@alexander-akait alexander-akait deleted the fix/deprecate-warning-cacert-option branch December 16, 2021 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants