Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use CLI specific description for --open-app-name and --web-socket-server #4215

Merged
merged 1 commit into from Jan 23, 2022

Conversation

snitin315
Copy link
Member

…`

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Updated snapshots.

Motivation / Use-Case

use CLI specific description for --open-app-name and --web-socket-server.

Mark these deprecations only for CLI flags.

Breaking Changes

None

Additional Info

No

@codecov
Copy link

codecov bot commented Jan 22, 2022

Codecov Report

Merging #4215 (3cc298a) into master (617f2d0) will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4215      +/-   ##
==========================================
+ Coverage   92.21%   92.34%   +0.12%     
==========================================
  Files          14       14              
  Lines        1541     1541              
  Branches      590      590              
==========================================
+ Hits         1421     1423       +2     
+ Misses        111      109       -2     
  Partials        9        9              
Impacted Files Coverage Δ
lib/Server.js 93.81% <0.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 617f2d0...3cc298a. Read the comment docs.

@snitin315
Copy link
Member Author

Rebased and fixed conflicts.

@snitin315 snitin315 merged commit 329679a into master Jan 23, 2022
@snitin315 snitin315 deleted the update-cli-des-open-app branch January 23, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants