Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add @types/express #4226

Merged
merged 3 commits into from Feb 1, 2022
Merged

fix: add @types/express #4226

merged 3 commits into from Feb 1, 2022

Conversation

snitin315
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Motivation / Use-Case

add @types/express as it is peer dependency for http-proxy-middleware.

Breaking Changes

None

Additional Info

No

@codecov
Copy link

codecov bot commented Jan 26, 2022

Codecov Report

Merging #4226 (e11e776) into master (ad1d14c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4226   +/-   ##
=======================================
  Coverage   92.34%   92.34%           
=======================================
  Files          14       14           
  Lines        1541     1541           
  Branches      590      590           
=======================================
  Hits         1423     1423           
  Misses        109      109           
  Partials        9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad1d14c...e11e776. Read the comment docs.

@snitin315
Copy link
Member Author

CI is failing for windows, looking into it.

@alexander-akait
Copy link
Member

I rerun tests, ping me when it will be green, we should do patch release

@snitin315
Copy link
Member Author

@alexander-akait one check failed in rerun.

@alexander-akait alexander-akait merged commit e55f728 into master Feb 1, 2022
@alexander-akait alexander-akait deleted the fix-types-express branch February 1, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants