Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update schema to have negatedDescription only for type boolean #4280

Merged
merged 1 commit into from Feb 15, 2022

Conversation

snitin315
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Already Present.

Motivation / Use-Case

negatedDescription field makes sense only for type boolean.

Breaking Changes

None

Additional Info

No

@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #4280 (8274603) into master (007104e) will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4280      +/-   ##
==========================================
+ Coverage   92.34%   92.47%   +0.12%     
==========================================
  Files          14       14              
  Lines        1541     1541              
  Branches      590      590              
==========================================
+ Hits         1423     1425       +2     
+ Misses        109      107       -2     
  Partials        9        9              
Impacted Files Coverage Δ
bin/cli-flags.js 100.00% <ø> (ø)
lib/servers/WebsocketServer.js 94.87% <0.00%> (+5.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 007104e...8274603. Read the comment docs.

@snitin315
Copy link
Member Author

Rebased with the master branch.

@snitin315 snitin315 merged commit fcf8e8e into master Feb 15, 2022
@snitin315 snitin315 deleted the fix-schema branch February 15, 2022 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants