Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update negated descriptions for more options #4287

Merged
merged 3 commits into from Feb 17, 2022
Merged

Conversation

snitin315
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Updated snaps.

Motivation / Use-Case

Updated descriptions for --no-client-overlay, --no-client-overlay-errors, --no-client-overlay-warnings.

Breaking Changes

None

Additional Info

No

@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #4287 (6ba09fc) into master (007104e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4287   +/-   ##
=======================================
  Coverage   92.34%   92.34%           
=======================================
  Files          14       14           
  Lines        1541     1541           
  Branches      590      590           
=======================================
  Hits         1423     1423           
  Misses        109      109           
  Partials        9        9           
Impacted Files Coverage Δ
bin/cli-flags.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcf8e8e...6ba09fc. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we fix/check all negative descriptions in one PR

@snitin315
Copy link
Member Author

Yes, let's keep it open for some time. I will add more here if found anything.

@snitin315 snitin315 changed the title fix: update negated descriptions for client.overlay options fix: update negated descriptions for more options Feb 17, 2022
@snitin315 snitin315 merged commit c64bd94 into master Feb 17, 2022
@snitin315 snitin315 deleted the update-overlay-des branch February 17, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants