Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compatibility with experiments.buildHttp #4585

Merged
merged 2 commits into from Sep 27, 2022

Conversation

alexander-akait
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

No need, existing tests

Motivation / Use-Case

fixes webpack/webpack#16091

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Base: 90.48% // Head: 92.00% // Increases project coverage by +1.51% 🎉

Coverage data is based on head (a250a69) compared to base (87c08f1).
Patch coverage: 85.71% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4585      +/-   ##
==========================================
+ Coverage   90.48%   92.00%   +1.51%     
==========================================
  Files          16       16              
  Lines        1639     1650      +11     
  Branches      617      621       +4     
==========================================
+ Hits         1483     1518      +35     
+ Misses        142      121      -21     
+ Partials       14       11       -3     
Impacted Files Coverage Δ
lib/Server.js 93.64% <85.71%> (+2.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alexander-akait alexander-akait merged commit 5b846cb into master Sep 27, 2022
@alexander-akait alexander-akait deleted the fix-experiments.buildHttp branch September 27, 2022 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enabling the experimental option experiments.buildHttp will cause HMR to not work.
1 participant