Do not show warnings @ 'overlay' unless explicitly set #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change tweaks the feature behavior (implemented @ webpack#790), so it matches the intended behavior (described @ webpack#789). This PR would supersede survivejs/webpack-book#262.
|
|
Codecov Report
@@ Coverage Diff @@
## master #881 +/- ##
=======================================
Coverage 72.13% 72.13%
=======================================
Files 4 4
Lines 463 463
Branches 139 139
=======================================
Hits 334 334
Misses 129 129Continue to review full report at Codecov.
|
|
Is it possible for this PR to be merged and a new webpack-dev-server bug-fix release be push to npm ASAP? I ask because this issue/behaviour is affecting projects built with the latest version of the angular-cli - 1.0.1 (angular-cli projects hard-code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change tweaks the feature behavior (implemented @ #790), so it matches the intended behavior (described @ #789):
This PR would supersede survivejs/webpack-book#262.
Did you add or update the
examples/?It wasn't needed, since the current example explicitly forces warnings to be shown/captured.
Does this PR introduce a breaking change?
Projects using the
overlay: trueoption would stop showing warnings, unless their Webpack config gets updated to explicitly show them.