Only load bonjour when needed

[joelface]

What kind of change does this PR introduce?
Bugfix for #955

Did you add or update the examples/?
n/a

Summary
Fixes #955 so WDS will work again on Windows 10 Bash (as long as the --bonjour option isn't specified).

Does this PR introduce a breaking change?
No

[jsf-clabot]

All committers have signed the CLA.

[codecov]

Codecov Report

Merging #958 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #958   +/-   ##
=======================================
  Coverage   72.13%   72.13%           
=======================================
  Files           4        4           
  Lines         463      463           
  Branches      139      139           
=======================================
  Hits          334      334           
  Misses        129      129

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5b6202...de11014. Read the comment docs.

[simnalamburt]

I tested it in my local WSL and it worked perfectly.

[rifflock]

Is this scheduled to be merged at any point? I'm currently using the workaround (which needs to be reimplemented after every npm install)

[simnalamburt]

Dear maintainers. If you're concerned about the coding style, let's do it like this

@@ -8,7 +8,7 @@ const net = require("net");
 const portfinder = require("portfinder");
 const addDevServerEntrypoints = require("../lib/util/addDevServerEntrypoints");
 const createDomain = require("../lib/util/createDomain");
-const bonjour = require("bonjour")();
+const Bonjour = require("bonjour");

 // Local version replaces global one
 try {
@@ -455,6 +455,7 @@ function reportReadiness(uri, options) {
 }

 function broadcastZeroconf(options) {
+       const bonjour = Bonjour();
        bonjour.publish({
                name: "Webpack Dev Server",
                port: options.port,

Reference

• simnalamburt@4bafab1

[andybarron]

Anything blocking this?

[drazisil]

It looks like @joelface needs to rebase. I'm not sure if that's blocking anything, but it's an issue per GitHub's PR UI that would prevent an easy merge.

[joelface]

@drazisil Taken care of.

I'm happy to make any changes necessary to get this merged in.

[drazisil]

@SpaceK33z Can you or another maintainer take a look at this PR?

It's somewhat blocking for Windows programmers, as npm/yarn install undoes the workaround each time.
Thank you in advance, and please let us know if anything else is needed.

[mredbishop]

Is this about to be merged in?

[shellscape]

folks, please try to hold off on the multiple comments asking about merge status and pinging contributors. it's awesome that you're all enthusiastic! but unfortunately it only serves to clutter the PR conversation and it's poor form. A much better way to go would be to add your reaction to the original post for this PR. maintainers, contributors, and admins will get to user submissions - webpack is a great org and makes sure that happens - but it's not our full time gig, and rest assured we see all of the notifications.