Could we strongly type LoaderContext?

[johnnyreilly]

Hey all!

Maintainer of ts-loader here. I'm just writing up the migration of ts-loader to be built / run it's test packs against webpack 5 on my blog: johnnyreilly/blog.johnnyreilly.com#35

One thing that happened as part of the migration was that we started using the TypeScript types that webpack ships with as of v5. This has been great! However, we did find one omission in the form of the LoaderContext which is typed as any:

webpack/lib/NormalModule.js

Line 424 in 03961f3

* @returns {any} loader context

Is this intentional? Or would it be possible for this to become strongly typed in future as well?

Looking at this:

webpack/lib/NormalModule.js

Line 593 in 03961f3

Object.assign(loaderContext, options.loader);

It would seem the type is something like this:

type LoaderContext = typeof loaderContext & typeof options.loader

Related PR: TypeStrong/ts-loader#1251

[johnnyreilly]

I've opened a speculative PR to demonstrate what I had in mind: #13164

What do you think?