-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test coverage for moduleFilenameHelpers
#16851
Comments
Hi, @TheLarkInn can I start working on this, can you please assign this to me.. |
You can send a PR |
This issue had no activity for at least three months. It's subject to automatic issue closing if there is no activity in the next 15 days. |
Issue was closed because of inactivity. If you think this is still a valid issue, please file a new issue with additional information. |
Hi @TheLarkInn - is this issue still open ? can i work on this ? |
@TheLarkInn I've opened a PR. But I couldn't test some parts of the file, because the examples/test cases you guys left out in the comments actually don't match the output the functions give. For
But the actual output starts counting from 0, ["a-0", "b-0", "c-0", "a-1", "b-1", "a-2"] For
but the actual output is true. Once you reply, I will first update the functions and then add tests for them. Let me know whether I should add the updates in a separate PR or the same one. Thanks ! I'm excited to make my first ever contribution that isn't just stylistic or a one-liner :)) |
After approving #16756, I realized we do not have coverage (that I could find) for this or other moduleFilenameHelper scenarios.
Documentation usages:
https://webpack.js.org/configuration/output/#outputdevtoolmodulefilenametemplate
Let's add a set of cases to cover this in tests.
The text was updated successfully, but these errors were encountered: