Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack 5.85.0 fails to correctly strip out parenthesis with barrel imports #17305

Closed
edusperoni opened this issue Jun 2, 2023 · 1 comment · Fixed by #17307
Closed

Webpack 5.85.0 fails to correctly strip out parenthesis with barrel imports #17305

edusperoni opened this issue Jun 2, 2023 · 1 comment · Fixed by #17307

Comments

@edusperoni
Copy link

edusperoni commented Jun 2, 2023

Bug report

What is the current behavior?

With the following code:


import * as barrel from './barrel';

console.log((barrel.something).nested);

Webpack will generate (notice the extra )):

(() => {
/*!*********************!*\
  !*** ./src/main.js ***!
  \*********************/
__webpack_require__.r(__webpack_exports__);
/* harmony import */ var _barrel__WEBPACK_IMPORTED_MODULE_0__ = __webpack_require__(/*! ./barrel */ "./src/barrel.js");



console.log(_barrel__WEBPACK_IMPORTED_MODULE_0__.something).nested);


})();

Under webpack 5.84.0, the code is correctly generated:

(() => {
/*!*********************!*\
  !*** ./src/main.js ***!
  \*********************/
__webpack_require__.r(__webpack_exports__);
/* harmony import */ var _barrel__WEBPACK_IMPORTED_MODULE_0__ = __webpack_require__(/*! ./barrel */ "./src/barrel.js");



console.log(_barrel__WEBPACK_IMPORTED_MODULE_0__.something.nested);


})();

If the current behavior is a bug, please provide the steps to reproduce.

https://github.com/edusperoni/webpack-import-paren-issue

Just run npm start

What is the expected behavior?

The parenthesis should be correctly stripped.

Other relevant information:
webpack version: 5.85.0

Reverting the change inlib/dependencies/HarmonyImportSpecifierDependency.js from @bworline fixes the issue:

https://github.com/webpack/webpack/pull/17203/files#diff-96335405b47eef62b17ba6fe88f6b35a1e37c9cf98fd762fe74599aca1c65d94R318-R353

@bworline
Copy link
Contributor

bworline commented Jun 2, 2023

I have a fix for this.

TheLarkInn added a commit that referenced this issue Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants