Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept undefined and null in plugins #17329

Closed
wants to merge 1 commit into from
Closed

Conversation

silverwind
Copy link

@silverwind silverwind commented Jun 5, 2023

Summary

🤖 Generated by Copilot at 792de0e

No summary available (An error occurred while summarizing these changes: Gave up after 3 retries: Failed to read error response)

Details

🤖 Generated by Copilot at 792de0e

No walkthrough available (An error occurred while summarizing these changes: Gave up after 3 retries: Failed to read error response)

@linux-foundation-easycla
Copy link

CLA Not Signed

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@silverwind
Copy link
Author

Too much effort for me to get this working and the CLA is too scary, so I'll not chase this further, but if someone wants to pick it up, feel free.

@alexander-akait
Copy link
Member

@silverwind What is the problem with CLI? It is a standard process for javascript foundation

@alexander-akait
Copy link
Member

Just want to know, maybe we can improve it

@silverwind
Copy link
Author

For one, I don't feel like handing out my postal address, It feels like a privacy intrusion. I prefer to contribute anonymously but that is certainly not possible here.

@alexander-akait
Copy link
Member

@silverwind I appreciate that you want to keep your privacy.

The main problem for us is that we can only accept the code on the condition that no one claims rights to it. And an email is required in order to link your commit and that you have agreed. If we remove this, then I see no other mechanism for us to make sure that you are you agreed to use your code.

But perhaps theoretically we can implement one time agreement into commit body. Thus, you do not have to go through such a procedure, but only write the required code (maybe one time generated for a PR) in the commit body.

I do not promise that I can solve this problem, because these are legal subtleties, but I will consult and try to find out how we can improve it.

@TheLarkInn
Copy link
Member

@silverwind we understand and appreciate your concern and I have brought this up with the OpenJS Foundation who owns our CLA process. As @alexander-akait I can't promise anything yet except that we will take a concernted effort into investigating it.

@silverwind
Copy link
Author

Thanks. I'm happy to give an e-mail address, not so happy to give out a real name, and anything more than those two is a no-go for me.

@TheLarkInn
Copy link
Member

@silverwind I've had a few discussions and have also formally opened a GitHub issue/agenda (openjs-foundation/cross-project-council#1088) item for the next OpenJSF Cross Project Council session. Looks like we can find a middle ground here but takes a bit of time/process just to iron it out. Appreciate the patience and understanding.

@TheLarkInn
Copy link
Member

@silverwind I'm adding you to our release note recongitions today as you transitively contributed to this feature landing today 🎉 congrats and thaank you so much! I'll continue to follow up with our discussion on CLA's so I hope we see your contributions in the future once we've resolved it 🙇

@silverwind
Copy link
Author

Thanks. Yeah, once the CLA issue is resolved/simplified, I could have a look at fixing webpack/webpack-dev-server#4630 😉.

@silverwind silverwind deleted the null branch June 14, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants