Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acorn not installed, but it's a peerDependency of acorn-dynamic-import #8779

Closed
worc opened this issue Feb 12, 2019 · 5 comments
Closed

acorn not installed, but it's a peerDependency of acorn-dynamic-import #8779

worc opened this issue Feb 12, 2019 · 5 comments

Comments

@worc
Copy link

worc commented Feb 12, 2019

versions:

  • node 10.15.1
  • npm 6.7.0
  • @storybook/react ^4.1.11 (which requires webpack@^4.23.1)

when i install just @storybook/react into my project, i get the following error:

npm WARN acorn-dynamic-import@4.0.0 requires a peer of acorn@^6.0.0 but none is installed. You must install peer dependencies yourself.

i've looked into acorn-dynamic-import (a plugin for acorn), and the issue isn't on their end. i've looked into acorn, but they're the main library and the problem isn't with them. i've looked into @storybook/react, but they're merely requiring webpack, the problem isn't with them. i've also opened a ticket with npm to see if there's a dependency resolution issue somewhere. the last place i haven't checked with is you guys, though i have my doubts here, both acorn and acorn-dynamic-import are "peer" dependencies in your dependency list.

i've been chasing this issue for a few weeks now, and i can't seem to get any traction with it. but if there's any thoughts on what else i should be looking into, that would be super helpful. the last bit that seems like it might be off is that webpack is using yarn, but i'm using npm in my project for dependency installation.

@sokra
Copy link
Member

sokra commented Feb 13, 2019

It's an npm bug. See #8656

@sokra sokra closed this as completed Feb 13, 2019
@worc
Copy link
Author

worc commented Feb 13, 2019

@jaydenseric
Copy link

npm reverted @sokra's fix for the final npm@6.8.0 release: npm/cli#152

It's unclear when npm will get around to fixing the issue.

@worc
Copy link
Author

worc commented Feb 19, 2019

oof. it's been like this for years, so i guess it's not that bad to just keep using yarn. but man, that's a strange decision on their part.

pascalw added a commit to kabisa/maji that referenced this issue Mar 26, 2019
@ekkis
Copy link

ekkis commented Aug 17, 2019

I have the problem with 6.10.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants