Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update acorn for dynamic import #9365

Closed
westn opened this issue Jul 4, 2019 · 5 comments
Closed

Update acorn for dynamic import #9365

westn opened this issue Jul 4, 2019 · 5 comments
Labels
Send a PR

Comments

@westn
Copy link

westn commented Jul 4, 2019

Perhaps an idea to update acorn and remove acorn-dynamic-import now when acornjs/acorn#834 is released (acorn 6.2.0)?
@alexander-akait
Copy link
Member

alexander-akait commented Jul 4, 2019 •
edited

@westn please use issue template

@sokra
Copy link
Member

sokra commented Jul 4, 2019

Actually it's not yet done for the next branch, so send a PR

@vankop
Copy link
Member

vankop commented Jul 7, 2019

Seems it is solved #9370

@alexander-akait
Copy link
Member

Yep, we can close 👍 need rebase for next too

@sokra
Copy link
Member

sokra commented Jul 8, 2019

need rebase for next too

We don't need that, as master is merged into next after each release.

@sokra sokra closed this as completed Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Send a PR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@westn @sokra @alexander-akait @vankop @webpack-bot