Improve Angular plugin a bit + add fixture/test (#717)

Author: webpro

packages/knip/fixtures/plugins/angular2/angular.json

@@ -0,0 +1,101 @@
+{
+  "version": 1,
+  "$schema": "./node_modules/@angular/cli/lib/config/schema.json",
+  "projects": {
+    "app": {
+      "root": "./",
+      "sourceRoot": "src",
+      "projectType": "application",
+      "prefix": "app",
+      "architect": {
+        "build-esbuild": {
+          "builder": "@angular-builders/custom-esbuild:application",
+          "options": {
+            "browser": "./src/browser.ts",
+            "index": "./src/index.html",
+            "outputPath": "./www",
+            "tsConfig": "./tsconfig.app.json",
+            "inlineStyleLanguage": "scss",
+            "crossOrigin": "anonymous"
+          }
+        },
+        "build": {
+          "builder": "@angular-devkit/build-angular:application",
+          "options": {
+            "outputPath": "dist/blorp",
+            "index": "src/index.html",
+            "browser": "src/main.ts",
+            "polyfills": ["zone.js"],
+            "tsConfig": "tsconfig.app.json",
+            "assets": [
+              {
+                "glob": "**/*",
+                "input": "public"
+              }
+            ],
+            "styles": ["src/styles.css"],
+            "scripts": [],
+            "server": "src/main.server.ts",
+            "prerender": true,
+            "ssr": {
+              "entry": "src/server.ts"
+            }
+          },
+          "configurations": {
+            "production": {
+              "budgets": [
+                {
+                  "type": "initial",
+                  "maximumWarning": "500kB",
+                  "maximumError": "1MB"
+                },
+                {
+                  "type": "anyComponentStyle",
+                  "maximumWarning": "2kB",
+                  "maximumError": "4kB"
+                }
+              ],
+              "outputHashing": "all"
+            },
+            "development": {
+              "optimization": false,
+              "extractLicenses": false,
+              "sourceMap": true
+            }
+          },
+          "defaultConfiguration": "production"
+        },
+        "serve": {
+          "builder": "@angular-devkit/build-angular:dev-server",
+          "configurations": {
+            "production": {
+              "buildTarget": "blorp:build:production"
+            },
+            "development": {
+              "buildTarget": "blorp:build:development"
+            }
+          },
+          "defaultConfiguration": "development"
+        },
+        "extract-i18n": {
+          "builder": "@angular-devkit/build-angular:extract-i18n"
+        },
+        "test": {
+          "builder": "@angular-devkit/build-angular:karma",
+          "options": {
+            "polyfills": ["zone.js", "zone.js/testing"],
+            "tsConfig": "tsconfig.spec.json",
+            "assets": [
+              {
+                "glob": "**/*",
+                "input": "public"
+              }
+            ],
+            "styles": ["src/styles.css"],
+            "scripts": []
+          }
+        }
+      }
+    }
+  }
+}

packages/knip/fixtures/plugins/angular2/node_modules/@angular/cli/index.js

@@ -0,0 +1,12 @@
+{
+  "name": "@fixtures/angular2",
+  "scripts": {
+    "ng": "ng"
+  },
+  "devDependencies": {
+    "@angular/cli": "*",
+    "@angular/ssr": "*",
+    "@angular-builders/custom-esbuild": "*",
+    "@angular-devkit/build-angular": "*"
+  }
+}

packages/knip/fixtures/plugins/angular2/node_modules/@angular/cli/package.json

@@ -0,0 +1 @@
+import { CommonEngine } from '@angular/ssr';

packages/knip/fixtures/plugins/angular2/package.json

@@ -0,0 +1 @@
+{}

packages/knip/fixtures/plugins/angular2/src/browser.ts

@@ -33,6 +33,14 @@ const resolveConfig: ResolveConfig<AngularCLIWorkspaceConfiguration> = async (co
         if ('main' in opts && typeof opts.main === 'string') {
           dependencies.add(toProductionEntryPattern(join(cwd, opts.main)));
         }
+        if ('browser' in opts && typeof opts.browser === 'string') {
+          dependencies.add(toProductionEntryPattern(join(cwd, opts.browser)));
+        }
+        if ('ssr' in opts && opts.ssr && typeof opts.ssr === 'object') {
+          if ('entry' in opts.ssr && typeof opts.ssr.entry === 'string') {
+            dependencies.add(toProductionEntryPattern(join(cwd, opts.ssr.entry)));
+          }
+        }
       }
     }
   }

packages/knip/fixtures/plugins/angular2/src/server.ts

@@ -0,0 +1,21 @@
+import { test } from 'bun:test';
+import assert from 'node:assert/strict';
+import { main } from '../../src/index.js';
+import { resolve } from '../../src/util/path.js';
+import baseArguments from '../helpers/baseArguments.js';
+import baseCounters from '../helpers/baseCounters.js';
+
+const cwd = resolve('fixtures/plugins/angular2');
+
+test('Find dependencies with the Angular plugin (2)', async () => {
+  const { counters } = await main({
+    ...baseArguments,
+    cwd,
+  });
+
+  assert.deepEqual(counters, {
+    ...baseCounters,
+    processed: 2,
+    total: 2,
+  });
+});