Reuse loadFile and ignore fake requests (resolves #325)

Author: webpro

src/plugins/husky/index.ts

@@ -1,9 +1,8 @@
-import { readFileSync } from 'fs';
 import { _getDependenciesFromScripts } from '../../binaries/index.js';
 import { getGitHookPaths } from '../../util/git.js';
 import { FAKE_PATH } from '../../util/loader.js';
 import { timerify } from '../../util/Performance.js';
-import { hasDependency } from '../../util/plugin.js';
+import { hasDependency, loadFile } from '../../util/plugin.js';
 import type { IsPluginEnabledCallback, GenericPluginCallback } from '../../types/plugins.js';
 
 // https://typicode.github.io/husky
@@ -25,7 +24,9 @@ const findHuskyDependencies: GenericPluginCallback = async (configFilePath, opti
 
   if (isProduction || configFilePath === FAKE_PATH) return [];
 
-  const script = readFileSync(configFilePath);
+  const script = await loadFile(configFilePath);
+
+  if (!script) return [];
 
   return _getDependenciesFromScripts(String(script), {
     cwd,

src/plugins/lefthook/index.ts

@@ -1,9 +1,8 @@
-import { readFileSync } from 'fs';
 import { _getDependenciesFromScripts } from '../../binaries/index.js';
 import { getGitHookPaths } from '../../util/git.js';
 import { getValuesByKeyDeep } from '../../util/object.js';
 import { timerify } from '../../util/Performance.js';
-import { hasDependency, load } from '../../util/plugin.js';
+import { hasDependency, load, loadFile } from '../../util/plugin.js';
 import { fromBinary } from '../../util/protocols.js';
 import type { IsPluginEnabledCallback, GenericPluginCallback } from '../../types/plugins.js';
 
@@ -35,7 +34,10 @@ const findLefthookDependencies: GenericPluginCallback = async (configFilePath, o
     return [...lefthook, ..._getDependenciesFromScripts(scripts, { cwd, manifest, knownGlobalsOnly: true })];
   }
 
-  const script = readFileSync(configFilePath, 'utf8');
+  const script = await loadFile(configFilePath);
+
+  if (!script) return [];
+
   const scriptDependencies = _getDependenciesFromScripts([script], { cwd, manifest, knownGlobalsOnly: false });
   const matches = scriptDependencies.find(dep => dependencies.includes(fromBinary(dep)));
   return matches ? [matches] : [];

src/util/loader.ts

@@ -31,10 +31,21 @@ const load = async (filePath: string) => {
       return imported.default ?? imported;
     }
 
-    return jiti(filePath);
+    return await jiti(filePath);
+  } catch (error) {
+    throw new LoaderError(`Error loading ${filePath}`, { cause: error });
+  }
+};
+
+const loadFileAsync = async (filePath: string) => {
+  // TODO: Turn into a config issue warning
+  if (filePath === FAKE_PATH) return;
+  try {
+    return await loadFile(filePath);
   } catch (error) {
     throw new LoaderError(`Error loading ${filePath}`, { cause: error });
   }
 };
 
 export const _load = timerify(load);
+export const _loadFile = timerify(loadFileAsync);

src/util/plugin.ts

@@ -1,4 +1,4 @@
-export { _load as load } from './loader.js';
+export { _load as load, _loadFile as loadFile } from './loader.js';
 import { arrayify } from './array.js';
 import type { RawPluginConfiguration } from '../types/config.js';