Start using virtual file paths for common imported extnames (resolves #322)

Author: webpro

fixtures/unresolved/node_modules/@svg-icons/fa-brands/github.svg

@@ -1,5 +1,9 @@
 {
   "name": "@fixtures/unresolved",
+  "dependencies": {
+    "@svg-icons/fa-brands": "*",
+    "@svg-icons/heroicons-outline": "*"
+  },
   "devDependencies": {
     "style-loader": "*"
   }

fixtures/unresolved/node_modules/@svg-icons/fa-brands/index.js

@@ -8,3 +8,11 @@ import Styles from '-!style-loader!css-loader?modules!./styles.css';
 import unresolved from './unresolved';
 import unresolvedPkg from 'unresolved';
 import unresolvedOrg from '@org/unresolved';
+
+import Github from '@svg-icons/fa-brands/github.svg';
+import Briefcase from '@svg-icons/heroicons-outline/briefcase.svg';
+
+import SomeSVG from 'common/image.svg';
+
+import './globals.css';
+import 'styles/base.css';

fixtures/unresolved/node_modules/@svg-icons/fa-brands/package.json

@@ -0,0 +1,9 @@
+{
+  "compilerOptions": {
+    "baseUrl": ".",
+    "paths": {
+      "common/*": ["src/common/*"],
+      "styles/*": ["src/styles/*"]
+    }
+  }
+}

fixtures/unresolved/node_modules/@svg-icons/heroicons-outline/briefcase.svg

@@ -200,16 +200,15 @@ export class ProjectPrincipal {
         }
       } else {
         const sanitizedSpecifier = sanitizeSpecifier(specifier);
-        const ext = extname(sanitizedSpecifier);
-        const hasIgnoredExtension = IGNORED_FILE_EXTENSIONS.includes(ext);
-        if (!hasIgnoredExtension && isMaybePackageName(sanitizedSpecifier)) {
+        if (isMaybePackageName(sanitizedSpecifier)) {
           // Should never end up here; maybe a dependency that was not installed.
           // Package name may contain such extensions, but any external dependency should be resolved by TS.
           external.add(sanitizedSpecifier);
         } else {
           const isIgnored = this.isGitIgnored(join(dirname(filePath), sanitizedSpecifier));
           if (!isIgnored) {
             const ext = extname(sanitizedSpecifier);
+            const hasIgnoredExtension = IGNORED_FILE_EXTENSIONS.includes(ext);
             if (!ext || (ext !== '.json' && !hasIgnoredExtension)) {
               unresolvedImports.add(specifier);
             }

fixtures/unresolved/node_modules/@svg-icons/heroicons-outline/index.js

@@ -43,9 +43,11 @@ export const IGNORED_GLOBAL_BINARIES = [
 
 export const IGNORED_DEPENDENCIES = ['knip', 'typescript'];
 
+export const VIRTUAL_FILE_EXTENSIONS = ['.css', '.html', '.svg'];
+
 export const IGNORED_FILE_EXTENSIONS = [
+  ...VIRTUAL_FILE_EXTENSIONS,
   '.avif',
-  '.css',
   '.eot',
   '.gif',
   '.ico',
@@ -55,7 +57,6 @@ export const IGNORED_FILE_EXTENSIONS = [
   '.png',
   '.sass',
   '.scss',
-  '.svg',
   '.sh',
   '.ttf',
   '.webp',

fixtures/unresolved/node_modules/@svg-icons/heroicons-outline/package.json

@@ -2,6 +2,7 @@ import { EOL } from 'node:os';
 // eslint-disable-next-line n/no-restricted-import
 import path from 'node:path';
 import ts from 'typescript';
+import { VIRTUAL_FILE_EXTENSIONS } from '../constants.js';
 import { createCustomModuleResolver } from './resolveModuleNames.js';
 import { SourceFileManager } from './SourceFileManager.js';
 import { createCustomSys } from './sys.js';
@@ -20,7 +21,7 @@ const fileManager = new SourceFileManager();
 
 export const createHosts = ({ cwd, compilerOptions, entryPaths, compilers }: CreateHostsOptions) => {
   fileManager.installCompilers(compilers);
-  const virtualFileExtensions = [...compilers[0].keys(), ...compilers[1].keys()];
+  const virtualFileExtensions = [...VIRTUAL_FILE_EXTENSIONS, ...compilers[0].keys(), ...compilers[1].keys()];
   const sys = createCustomSys(cwd, virtualFileExtensions);
   const resolveModuleNames = createCustomModuleResolver(sys, compilerOptions, virtualFileExtensions);