Support husky v9 (#500)

* Support husky v9

* Keep the behavior for husky v8 or lower

* Split test for husky into v8 and v9

Author: risu729

package-lock.json

@@ -1,13 +1,13 @@
 {
-  "name": "@fixtures/husky",
+  "name": "@fixtures/husky-v8",
   "scripts": {
     "prepare": "husky install",
     "build": "node",
     "test": "node"
   },
   "devDependencies": {
     "@commitlint/cli": "*",
-    "husky": "*",
+    "husky": "8.0.0",
     "lint-staged": "*"
   }
 }

packages/knip/fixtures/plugins/husky/.husky/post-checkout renamed to packages/knip/fixtures/plugins/husky-v8/.husky/post-checkout

@@ -0,0 +1 @@
+yarn install

packages/knip/fixtures/plugins/husky/.husky/pre-commit renamed to packages/knip/fixtures/plugins/husky-v8/.husky/pre-commit

@@ -0,0 +1,3 @@
+npx lint-staged
+npx --no-install commitlint --edit "$1"
+npm test

packages/knip/fixtures/plugins/husky/.husky/pre-push renamed to packages/knip/fixtures/plugins/husky-v8/.husky/pre-push

@@ -0,0 +1,2 @@
+yarn jest
+yarn pretty-quick --check

packages/knip/fixtures/plugins/husky/.husky/pre-rebase renamed to packages/knip/fixtures/plugins/husky-v8/.husky/pre-rebase

@@ -0,0 +1,3 @@
+pnpm build
+pnpm eslint
+pnpm lint-staged

packages/knip/fixtures/plugins/husky/node_modules/@commitlint/cli/package.json renamed to packages/knip/fixtures/plugins/husky-v8/node_modules/@commitlint/cli/package.json

@@ -0,0 +1,13 @@
+{
+  "name": "@fixtures/husky-v9",
+  "scripts": {
+    "prepare": "husky",
+    "build": "node",
+    "test": "node"
+  },
+  "devDependencies": {
+    "@commitlint/cli": "*",
+    "husky": "9.0.0",
+    "lint-staged": "*"
+  }
+}

packages/knip/fixtures/plugins/husky/node_modules/husky/package.json renamed to packages/knip/fixtures/plugins/husky-v8/node_modules/husky/package.json

@@ -70,6 +70,7 @@
     "picocolors": "1.0.0",
     "picomatch": "4.0.1",
     "pretty-ms": "9.0.0",
+    "semver": "7.6.0",
     "smol-toml": "1.1.4",
     "strip-json-comments": "5.0.1",
     "summary": "2.1.0",
@@ -91,6 +92,7 @@
     "@types/minimist": "^1.2.5",
     "@types/npmcli__map-workspaces": "^3.0.4",
     "@types/npmcli__package-json": "^4.0.3",
+    "@types/semver": "7.5.6",
     "@types/webpack": "^5.28.5",
     "c8": "9.1.0",
     "eslint": "^8.56.0",

packages/knip/fixtures/plugins/husky/node_modules/lint-staged/package.json renamed to packages/knip/fixtures/plugins/husky-v8/node_modules/lint-staged/package.json

@@ -1,3 +1,4 @@
+import semver from 'semver';
 import { getGitHookPaths } from '../../util/git.js';
 import { timerify } from '../../util/Performance.js';
 import { getDependenciesFromScripts, hasDependency, loadFile } from '../../util/plugin.js';
@@ -11,15 +12,35 @@ const ENABLERS = ['husky'];
 
 const isEnabled: IsPluginEnabledCallback = ({ dependencies }) => hasDependency(dependencies, ENABLERS);
 
-const gitHookPaths = getGitHookPaths('.husky');
+const gitHooksPathInV8 = getGitHookPaths('.husky', true);
+// husky v9 registers hooks in .husky/_/ to git and calls user defined hooks in .husky/ from there
+const gitHookPathsInV9 = getGitHookPaths('.husky', false);
 
-const CONFIG_FILE_PATTERNS = [...gitHookPaths];
+// Add patterns for both v8 and v9 because we can't know which version is installed at this point
+const CONFIG_FILE_PATTERNS = [...gitHooksPathInV8, ...gitHookPathsInV9];
 
 const findHuskyDependencies: GenericPluginCallback = async (configFilePath, options) => {
-  const { isProduction } = options;
+  const { isProduction, manifest } = options;
 
   if (isProduction) return [];
 
+  const huskyVersion = manifest.devDependencies?.husky ?? manifest.dependencies?.husky ?? '*';
+
+  // Ignore config files that are not used by the installed husky version
+  const isV8OrLower = semver.intersects(huskyVersion, '<9', {
+    includePrerelease: true,
+  });
+  if (!isV8OrLower && gitHooksPathInV8.some(path => configFilePath.includes(path))) {
+    return [];
+  }
+
+  const isV9OrHigher = semver.intersects(huskyVersion, '>=9', {
+    includePrerelease: true,
+  });
+  if (!isV9OrHigher && gitHookPathsInV9.some(path => configFilePath.includes(path))) {
+    return [];
+  }
+
   const script = await loadFile(configFilePath);
 
   if (!script) return [];

packages/knip/fixtures/plugins/husky/package.json renamed to packages/knip/fixtures/plugins/husky-v8/package.json

@@ -20,7 +20,7 @@ const getGitHooksPath = (defaultPath = '.git/hooks') => {
   }
 };
 
-export const getGitHookPaths = (defaultPath = '.git/hooks') => {
-  const gitHooksPath = getGitHooksPath(defaultPath);
+export const getGitHookPaths = (defaultPath = '.git/hooks', followGitConfig = true) => {
+  const gitHooksPath = followGitConfig ? getGitHooksPath(defaultPath) : defaultPath;
   return hookFileNames.map(fileName => join(gitHooksPath, fileName));
 };

packages/knip/fixtures/plugins/husky-v9/.husky/post-checkout

@@ -7,16 +7,16 @@ import baseArguments from '../helpers/baseArguments.js';
 import baseCounters from '../helpers/baseCounters.js';
 import { buildOptions } from '../helpers/index.js';
 
-const cwd = resolve('fixtures/plugins/husky');
+const cwd = resolve('fixtures/plugins/husky-v8');
 const options = buildOptions(cwd);
 
-test('Find dependencies in husky configuration (plugin)', async () => {
+test('Find dependencies in husky v8 configuration (plugin)', async () => {
   const configFilePath = join(cwd, '.husky/pre-commit');
   const dependencies = await husky.findDependencies(configFilePath, options);
   assert.deepEqual(dependencies, ['lint-staged', 'bin:commitlint']);
 });
 
-test('Find dependencies in husky configuration (main)', async () => {
+test('Find dependencies in husky v8 configuration (main)', async () => {
   const { issues, counters } = await main({
     ...baseArguments,
     cwd,

packages/knip/fixtures/plugins/husky-v9/.husky/pre-commit

@@ -0,0 +1,35 @@
+import assert from 'node:assert/strict';
+import test from 'node:test';
+import { main } from '../../src/index.js';
+import { default as husky } from '../../src/plugins/husky/index.js';
+import { resolve, join } from '../../src/util/path.js';
+import baseArguments from '../helpers/baseArguments.js';
+import baseCounters from '../helpers/baseCounters.js';
+import { buildOptions } from '../helpers/index.js';
+
+const cwd = resolve('fixtures/plugins/husky-v9');
+const options = buildOptions(cwd);
+
+test('Find dependencies in husky v9 configuration (plugin)', async () => {
+  const configFilePath = join(cwd, '.husky/pre-commit');
+  const dependencies = await husky.findDependencies(configFilePath, options);
+  assert.deepEqual(dependencies, ['lint-staged', 'bin:commitlint']);
+});
+
+test('Find dependencies in husky v9 configuration (main)', async () => {
+  const { issues, counters } = await main({
+    ...baseArguments,
+    cwd,
+  });
+
+  assert(issues.binaries['.husky/pre-push']['jest']);
+  assert(issues.binaries['.husky/pre-push']['pretty-quick']);
+  assert(issues.binaries['.husky/pre-rebase']['eslint']);
+
+  assert.deepEqual(counters, {
+    ...baseCounters,
+    binaries: 3,
+    processed: 0,
+    total: 0,
+  });
+});