Require eslint-config-prettier if eslint-plugin-prettier is in `e…

…xtends` (fixes #128)
webpro · May 17, 2023 · 3655301 · 3655301
1 parent ce29c84
commit 3655301
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/src/plugins/eslint/helpers.ts b/src/plugins/eslint/helpers.ts
@@ -12,6 +12,8 @@ type Manifest = PackageJson & { eslintConfig?: ESLintConfig };
 const getDependencies = (config: ESLintConfig | OverrideConfig) => {
   const extendsSpecifiers = config.extends ? [config.extends].flat().map(resolveExtendsSpecifier) : [];
   const plugins = config.plugins ? config.plugins.map(resolvePluginPackageName) : [];
+  // https://github.com/prettier/eslint-plugin-prettier#recommended-configuration
+  if (extendsSpecifiers.includes('eslint-plugin-prettier')) extendsSpecifiers.push('eslint-config-prettier');
   const parser = config.parser;
   const extraParsers = config.parserOptions?.babelOptions?.presets ?? [];
   const settings = config.settings ? getDependenciesFromSettings(config.settings) : [];

diff --git a/tests/fixtures/plugins/eslint/.eslintrc.js b/tests/fixtures/plugins/eslint/.eslintrc.js
@@ -3,7 +3,6 @@ module.exports = {
   extends: [
     require.resolve('./base.eslint.json'),
     'airbnb',
-    'plugin:prettier/recommended',
     'plugin:@typescript-eslint/recommended',
     'plugin:@typescript-eslint/eslint-recommended',
     'plugin:@typescript-eslint/recommended-requiring-type-checking',
@@ -13,8 +12,9 @@ module.exports = {
     'plugin:eslint-comments/recommended',
     'plugin:eslint-plugin/all',
     '@scope/eslint-config/file',
+    'plugin:prettier/recommended',
   ],
-  plugins: ['@typescript-eslint', '@nrwl/nx', 'prettier', 'eslint-plugin-cypress', '@scope/eslint-plugin'],
+  plugins: ['@typescript-eslint', '@nrwl/nx', 'eslint-plugin-cypress', '@scope/eslint-plugin'],
   settings: {
     'import/resolver': {
       typescript: true,

diff --git a/tests/plugins/eslint.test.ts b/tests/plugins/eslint.test.ts
@@ -29,13 +29,14 @@ test('Find dependencies in ESLint configuration (legacy js)', async () => {
     'eslint-plugin-import',
     '@typescript-eslint/parser',
     'eslint-config-airbnb',
-    'eslint-plugin-prettier',
     '@typescript-eslint/eslint-plugin',
     'eslint-config-next',
     '@next/eslint-plugin-next',
     'eslint-plugin-eslint-comments',
     'eslint-plugin-eslint-plugin',
     '@scope/eslint-config/file',
+    'eslint-plugin-prettier',
+    'eslint-config-prettier',
     '@nrwl/eslint-plugin-nx',
     'eslint-plugin-cypress',
     '@scope/eslint-plugin',