Do not return react as a dependency for jsx: preserve/none in typescript plugin (#226)

Author: webpro

Diff for: fixtures/plugins/typescript/tsconfig-jsx-preserve.json

@@ -0,0 +1,5 @@
+{
+  "compilerOptions": {
+    "jsx": "preserve"
+  }
+}

Diff for: src/plugins/typescript/index.ts

@@ -1,3 +1,4 @@
+import ts from 'typescript';
 import { compact } from '../../util/array.js';
 import { dirname, isInternal, toAbsolute } from '../../util/path.js';
 import { timerify } from '../../util/Performance.js';
@@ -33,6 +34,8 @@ const resolveExtensibleConfig = async (configFilePath: string) => {
   return config;
 };
 
+const jsxWithReact = [ts.JsxEmit.React, ts.JsxEmit.ReactJSX, ts.JsxEmit.ReactJSXDev, ts.JsxEmit.ReactNative];
+
 const findTypeScriptDependencies: GenericPluginCallback = async configFilePath => {
   const compilerOptions: CompilerOptions = await loadTSConfig(configFilePath);
   const config: TsConfigJson = await resolveExtensibleConfig(configFilePath); // Dual loader to get external `extends` dependencies
@@ -47,7 +50,7 @@ const findTypeScriptDependencies: GenericPluginCallback = async configFilePath =
   const importHelpers = compilerOptions?.importHelpers ? ['tslib'] : [];
   const jsx = compilerOptions?.jsxImportSource
     ? [compilerOptions.jsxImportSource]
-    : compilerOptions?.jsx
+    : compilerOptions?.jsx && jsxWithReact.includes(compilerOptions.jsx)
     ? ['react']
     : [];
   return compact([...extend, ...types, ...plugins, ...importHelpers, ...jsx]);

Diff for: tests/plugins/typescript.test.ts

@@ -16,6 +16,12 @@ test('Find dependencies in typescript configuration', async () => {
   ]);
 });
 
+test('Find dependencies in typescript configuration (jsx-preserve)', async () => {
+  const configFilePath = join(cwd, 'tsconfig-jsx-preserve.json');
+  const dependencies = await typescript.findDependencies(configFilePath);
+  assert.deepEqual(dependencies, []);
+});
+
 test('Find dependencies in typescript configuration (jsx)', async () => {
   const configFilePath = join(cwd, 'tsconfig-jsx.json');
   const dependencies = await typescript.findDependencies(configFilePath);