Respect ignore option for entry paths from manifest

Author: webpro

src/index.ts

@@ -160,7 +160,7 @@ export const main = async (unresolvedConfiguration: CommandLineOptions) => {
 
     const sharedGlobOptions = { cwd, workingDir: dir, gitignore, ignore: worker.getIgnorePatterns() };
 
-    const entryPathsFromManifest = await getEntryPathFromManifest(cwd, dir, manifest);
+    const entryPathsFromManifest = await getEntryPathFromManifest(manifest, sharedGlobOptions);
     debugLogArray(name, 'Entry paths in package.json', entryPathsFromManifest);
     principal.addEntryPaths(entryPathsFromManifest);
 

src/util/glob.ts

@@ -44,7 +44,7 @@ const glob = async ({ cwd, workingDir = cwd, patterns, ignore = [], gitignore =
 
   const ignorePatterns = compact([...ignore, ...GLOBAL_IGNORE_PATTERNS]);
 
-  debugLogObject(relativePath || ROOT_WORKSPACE_NAME, `Glob options`, { cwd, globPatterns, ignorePatterns });
+  debugLogObject(relativePath || ROOT_WORKSPACE_NAME, `Glob options`, { cwd, globPatterns, ignorePatterns, gitignore });
 
   return globby(globPatterns, {
     cwd,

src/util/modules.ts

@@ -39,7 +39,10 @@ export const getPackageFromDefinitelyTyped = (typedDependency: string) => {
   return typedDependency;
 };
 
-export const getEntryPathFromManifest = (cwd: string, dir: string, manifest: PackageJson) => {
+export const getEntryPathFromManifest = (
+  manifest: PackageJson,
+  sharedGlobOptions: { cwd: string; workingDir: string; gitignore: boolean; ignore: string[] }
+) => {
   const { main, bin, exports } = manifest;
 
   const entryPaths: Set<string> = new Set();
@@ -55,8 +58,11 @@ export const getEntryPathFromManifest = (cwd: string, dir: string, manifest: Pac
     getStringValues(exports).forEach(item => entryPaths.add(item));
   }
 
-  // Glob, as we only want source files that exist and not (generated) files that are .gitignore'd
-  return _glob({ cwd, workingDir: dir, patterns: Array.from(entryPaths) });
+  // Use glob, as we only want source files that:
+  // - exist
+  // - are not (generated) files that are .gitignore'd
+  // - do not match configured `ignore` patterns
+  return _glob({ ...sharedGlobOptions, patterns: Array.from(entryPaths) });
 };
 
 // Strip `?search` and other proprietary directives from the specifier (e.g. https://webpack.js.org/concepts/loaders/)

test/helpers/baseArguments.ts

@@ -1,6 +1,6 @@
 const baseArguments = {
   cwd: '.',
-  gitignore: false,
+  gitignore: true,
   isStrict: false,
   isProduction: false,
   isIgnoreInternal: false,

test/unresolved-rtl.test.ts

@@ -15,7 +15,7 @@ test('Report unresolved imports (rtl)', async () => {
 
   assert.deepEqual(counters, {
     ...baseCounters,
-    processed: 2,
-    total: 2,
+    processed: 1,
+    total: 1,
   });
 });

test/unresolved.test.ts

@@ -21,7 +21,7 @@ test('Report unresolved imports', async () => {
     ...baseCounters,
     unlisted: 2,
     unresolved: 1,
-    processed: 2,
-    total: 2,
+    processed: 1,
+    total: 1,
   });
 });