Support force-enabling of plugins, by with value object or true (re…

…solves #276)

fixtures/workspaces-plugin-config/knip.json

@@ -3,6 +3,9 @@
     "config": ["vitest.config.ts"],
     "entry": ["**/*.vitest.ts"]
   },
+  "eslint": true,
+  "jest": "jest.config.js",
+  "babel": { "config": "rollup.config.ts" },
   "workspaces": {
     "packages/*": {}
   }

fixtures/workspaces-plugin-config/package.json

@@ -2,5 +2,9 @@
   "name": "@workspaces-plugin-config/root",
   "workspaces": [
     "packages/*"
-  ]
+  ],
+  "devDependencies": {
+    "jest-result-processor": "*",
+    "eslint-config-airbnb": "*"
+  }
 }

fixtures/workspaces-plugin-config/packages/backend/jest.config.js

@@ -0,0 +1,3 @@
+module.exports = {
+  testResultsProcessor: 'jest-result-processor',
+};

fixtures/workspaces-plugin-config/packages/frontend/.eslintrc.js

@@ -0,0 +1,3 @@
+module.exports = {
+  extends: ['airbnb'],
+};

fixtures/workspaces-plugin-config/packages/frontend/package.json

@@ -5,6 +5,7 @@
   },
   "devDependencies": {
     "vitest": "*",
-    "jsdom": "*"
+    "jsdom": "*",
+    "@rollup/plugin-commonjs": "*"
   }
 }

fixtures/workspaces-plugin-config/packages/frontend/rollup.config.ts

@@ -0,0 +1 @@
+import commonjs from '@rollup/plugin-commonjs';

src/ConfigurationValidator.ts

@@ -63,7 +63,7 @@ const reportConfigSchema = z.object({
 });
 
 export const pluginSchema = z.union([
-  z.literal(false),
+  z.boolean(),
   globSchema,
   z.object({
     config: globSchema.optional(),

src/WorkspaceWorker.ts

@@ -29,6 +29,8 @@ type ReferencedDependencies = Set<[string, string]>;
 
 const negatedTestFilePatterns = TEST_FILE_PATTERNS.map(negate);
 
+const nullConfig = { config: null, entry: null, project: null };
+
 /**
  * - Determines enabled plugins
  * - Finds referenced dependencies and binaries in npm scripts
@@ -99,6 +101,10 @@ export class WorkspaceWorker {
 
     for (const [pluginName, plugin] of pluginEntries) {
       if (this.config[pluginName] === false) continue;
+      if (this.config[pluginName]) {
+        this.enabled[pluginName] = true;
+        continue;
+      }
       const isEnabledInAncestor = this.enabledPluginsInAncestors.includes(pluginName);
       if (
         isEnabledInAncestor ||
@@ -132,7 +138,7 @@ export class WorkspaceWorker {
   }
 
   private getConfigForPlugin(pluginName: PluginName): PluginConfiguration {
-    return this.config[pluginName] ?? { config: null, entry: null, project: null };
+    return this.config[pluginName] ?? nullConfig;
   }
 
   getEntryFilePatterns() {
@@ -164,7 +170,7 @@ export class WorkspaceWorker {
     for (const [pluginName, plugin] of Object.entries(plugins) as PluginNames) {
       const pluginConfig = this.getConfigForPlugin(pluginName);
       if (this.enabled[pluginName] && pluginConfig) {
-        const { entry } = pluginConfig;
+        const { entry } = pluginConfig === true ? nullConfig : pluginConfig;
         const defaultEntryFiles = 'ENTRY_FILE_PATTERNS' in plugin ? plugin.ENTRY_FILE_PATTERNS : [];
         patterns.push(...(entry ?? defaultEntryFiles));
         if (isIncludeProductionEntryFiles) {
@@ -181,7 +187,7 @@ export class WorkspaceWorker {
     for (const [pluginName, plugin] of Object.entries(plugins) as PluginNames) {
       const pluginConfig = this.getConfigForPlugin(pluginName);
       if (this.enabled[pluginName] && pluginConfig) {
-        const { entry, project } = pluginConfig;
+        const { entry, project } = pluginConfig === true ? nullConfig : pluginConfig;
         patterns.push(
           ...(project ??
             entry ??
@@ -201,7 +207,7 @@ export class WorkspaceWorker {
     for (const [pluginName, plugin] of Object.entries(plugins) as PluginNames) {
       const pluginConfig = this.getConfigForPlugin(pluginName);
       if (this.enabled[pluginName] && pluginConfig) {
-        const { config } = pluginConfig;
+        const { config } = pluginConfig === true ? nullConfig : pluginConfig;
         const defaultConfigFiles = 'CONFIG_FILE_PATTERNS' in plugin ? plugin.CONFIG_FILE_PATTERNS : [];
         patterns.push(...(config ?? defaultConfigFiles));
       }
@@ -245,7 +251,9 @@ export class WorkspaceWorker {
       const pluginConfig = this.getConfigForPlugin(pluginName);
       if (this.enabled[pluginName] && pluginConfig) {
         if ('PRODUCTION_ENTRY_FILE_PATTERNS' in plugin) {
-          patterns.push(...(pluginConfig.entry ?? plugin.PRODUCTION_ENTRY_FILE_PATTERNS));
+          patterns.push(
+            ...((pluginConfig === true ? null : pluginConfig.entry) ?? plugin.PRODUCTION_ENTRY_FILE_PATTERNS)
+          );
         }
       }
     }
@@ -258,7 +266,7 @@ export class WorkspaceWorker {
     const pluginConfig = this.getConfigForPlugin(pluginName);
     if (pluginConfig) {
       const defaultConfig = 'CONFIG_FILE_PATTERNS' in plugin ? plugin.CONFIG_FILE_PATTERNS : [];
-      return pluginConfig.config ?? defaultConfig;
+      return (pluginConfig === true ? null : pluginConfig.config) ?? defaultConfig;
     }
     return [];
   }

src/types/config.ts

@@ -18,7 +18,7 @@ export type PluginConfiguration =
       entry: NormalizedGlob | null;
       project: NormalizedGlob | null;
     }
-  | false;
+  | boolean;
 
 export type PluginsConfiguration = Record<PluginName, PluginConfiguration>;
 

src/util/plugin.ts

@@ -18,8 +18,8 @@ export const hasDependency = (dependencies: Set<string>, values: (string | RegEx
   });
 
 export const normalizePluginConfig = (pluginConfig: RawPluginConfiguration) => {
-  if (pluginConfig === false) {
-    return false;
+  if (typeof pluginConfig === 'boolean') {
+    return pluginConfig;
   } else {
     const isObject = typeof pluginConfig !== 'string' && !Array.isArray(pluginConfig);
     const config = isObject ? arrayify(pluginConfig.config) : pluginConfig ? arrayify(pluginConfig) : null;

tests/workspaces-plugin-config.test.ts

@@ -15,7 +15,7 @@ test('Use root plugin config in workspaces', async () => {
 
   assert.deepEqual(counters, {
     ...baseCounters,
-    total: 6,
-    processed: 6,
+    total: 9,
+    processed: 9,
   });
 });