Fix up plugin resolving in graphql-codegen plugin a bit (resolves #349)

Author: webpro

fixtures/plugins/graphql-codegen/codegen.yaml

@@ -0,0 +1,30 @@
+generates:
+  '../../packages/graphql-types/src/types.ts':
+    config:
+    documents:
+      'src/documents/**/*.graphql':
+        skipGraphQLImport: false
+    plugins:
+      - typescript
+      - typescript-operations
+      - typed-document-node
+      - ./codegen/UserErrorsPlugin.cjs
+      - add:
+          content: "/* cSpell:disable */\nimport { type SerializedMoney } from '@contra/money';"
+  'src/contra-api/__generated__/types.ts':
+    config:
+      contextType: '../types.js#ResolverContext'
+      mappers:
+        ActivePaidProjectAnalytics: '../types.js#ActivePaidProjectAnalytics'
+        Workspace: '@contra/temporary-common/domain/workspace/WorkspaceService.js#Workspace'
+    plugins:
+      - typescript
+      - typescript-resolvers
+      - ./codegen/UserErrorsPlugin.cjs
+      - ./codegen/GraphQLResolverBuilderPlugin.cjs
+      - add:
+          content:
+            "/* cSpell:disable */\nimport type { DeepPartial } from 'utility-types';\nimport { type Money as
+            ContraMoney, type USD } from '@contra/money';"
+schema:
+  - node_modules/@contra/graphql-schema/index.js

src/plugins/graphql-codegen/index.ts

@@ -1,5 +1,7 @@
+import { isInternal } from '../../util/path.js';
 import { timerify } from '../../util/Performance.js';
 import { hasDependency, load } from '../../util/plugin.js';
+import { toEntryPattern } from '../../util/protocols.js';
 import { isConfigurationOutput } from './types.js';
 import type { ConfiguredPlugin, GraphqlCodegenTypes, PresetNames } from './types.js';
 import type { IsPluginEnabledCallback, GenericPluginCallback } from '../../types/plugins.js';
@@ -50,7 +52,11 @@ const findPluginDependencies: GenericPluginCallback = async (configFilePath, opt
 
   const nestedPlugins = configurationOutput
     .flatMap(configOutput => (configOutput.plugins ? configOutput.plugins : []))
-    .map(plugin => `@graphql-codegen/${plugin}`);
+    .flatMap(plugin => {
+      if (typeof plugin !== 'string') return [];
+      if (isInternal(plugin)) return [toEntryPattern(plugin)];
+      return [`@graphql-codegen/${plugin}`];
+    });
 
   return [...presets, ...flatPlugins, ...nestedPlugins];
 };

test/plugins/graphql-codegen.test.ts

@@ -31,6 +31,21 @@ test('Find dependencies in graphql-codegen configuration (codegen.ts)', async ()
   ]);
 });
 
+test('Find dependencies in graphql-codegen configuration (codegen.yaml)', async () => {
+  const configFilePath = join(cwd, 'codegen.yaml');
+  const dependencies = await graphqlCodegen.findDependencies(configFilePath, { manifest, config });
+  assert.deepEqual(dependencies, [
+    '@graphql-codegen/typescript',
+    '@graphql-codegen/typescript-operations',
+    '@graphql-codegen/typed-document-node',
+    'entry:./codegen/UserErrorsPlugin.cjs',
+    '@graphql-codegen/typescript',
+    '@graphql-codegen/typescript-resolvers',
+    'entry:./codegen/UserErrorsPlugin.cjs',
+    'entry:./codegen/GraphQLResolverBuilderPlugin.cjs',
+  ]);
+});
+
 test('Find dependencies in graphql-codegen configuration (codegen.ts function)', async () => {
   const { issues, counters } = await main({
     ...baseArguments,
@@ -44,11 +59,17 @@ test('Find dependencies in graphql-codegen configuration (codegen.ts function)',
   assert(issues.unlisted['codegen.ts']['@graphql-codegen/typescript-operations']);
   assert(issues.unlisted['codegen.ts']['@graphql-codegen/typescript-urql']);
   assert(issues.unlisted['codegen.ts']['@graphql-codegen/typescript-msw']);
+
+  // TODO split in separate fixtures/dirs
+  assert(issues.unlisted['codegen.yaml']['@graphql-codegen/typescript']);
+  assert(issues.unlisted['codegen.yaml']['@graphql-codegen/typescript-operations']);
+  assert(issues.unlisted['codegen.yaml']['@graphql-codegen/typed-document-node']);
+  assert(issues.unlisted['codegen.yaml']['@graphql-codegen/typescript-resolvers']);
   assert(issues.unlisted['package.json']['@graphql-codegen/client-preset']);
 
   assert.deepEqual(counters, {
     ...baseCounters,
-    unlisted: 8,
+    unlisted: 12,
     devDependencies: 1,
     processed: 1,
     total: 1,