Exclude negated production patterns in default mode (resolves #352)

Author: webpro

packages/knip/fixtures/negated-production-paths/index.test.ts

@@ -0,0 +1,4 @@
+{
+  "entry": ["*.ts!", "!*.test.ts!"],
+  "project": ["**/*.ts!", "!*.test.ts!"]
+}

packages/knip/fixtures/negated-production-paths/index.ts

@@ -0,0 +1,3 @@
+{
+  "name": "@fixtures/negated-production-paths"
+}

packages/knip/fixtures/negated-production-paths/knip.json

@@ -28,7 +28,7 @@
         "entry": "index.ts!",
         "project": [
           "**/*.ts!",
-          "!ignored/*.ts!"
+          "!ignored/*.ts"
         ]
       }
     }

packages/knip/fixtures/negated-production-paths/package.json

@@ -152,18 +152,20 @@ export class WorkspaceWorker {
   getEntryFilePatterns() {
     const { entry } = this.config;
     if (entry.length === 0) return [];
-    return [entry, this.negatedWorkspacePatterns].flat();
+    const excludeProductionNegations = entry.filter(pattern => !(pattern.startsWith('!') && pattern.endsWith('!')));
+    return [excludeProductionNegations, this.negatedWorkspacePatterns].flat();
   }
 
   getProjectFilePatterns(testFilePatterns: string[]) {
     const { project } = this.config;
     if (project.length === 0) return [];
 
+    const excludeProductionNegations = project.filter(pattern => !(pattern.startsWith('!') && pattern.endsWith('!')));
     const negatedPluginConfigPatterns = this.getPluginConfigPatterns().map(negate);
     const negatedPluginProjectFilePatterns = this.getPluginProjectFilePatterns().map(negate);
 
     return [
-      project,
+      excludeProductionNegations,
       negatedPluginConfigPatterns,
       negatedPluginProjectFilePatterns,
       testFilePatterns,

packages/knip/fixtures/workspaces/package.json

@@ -0,0 +1,35 @@
+import assert from 'node:assert/strict';
+import test from 'node:test';
+import { main } from '../src/index.js';
+import { resolve } from '../src/util/path.js';
+import baseArguments from './helpers/baseArguments.js';
+import baseCounters from './helpers/baseCounters.js';
+
+const cwd = resolve('fixtures/negated-production-paths');
+
+test('Exclude negated production paths', async () => {
+  const { counters } = await main({
+    ...baseArguments,
+    cwd,
+  });
+
+  assert.deepEqual(counters, {
+    ...baseCounters,
+    processed: 2,
+    total: 2,
+  });
+});
+
+test('Respect negated paths (production)', async () => {
+  const { counters } = await main({
+    ...baseArguments,
+    cwd,
+    isProduction: true,
+  });
+
+  assert.deepEqual(counters, {
+    ...baseCounters,
+    processed: 1,
+    total: 1,
+  });
+});