Use a single centralized isGitIgnored fn

Author: webpro

src/PrincipalFactory.ts

@@ -2,18 +2,20 @@ import ts from 'typescript';
 import { ProjectPrincipal } from './ProjectPrincipal.js';
 import { toAbsolute } from './util/path.js';
 import type { SyncCompilers, AsyncCompilers } from './types/compilers.js';
+import type { GlobbyFilterFunction } from 'globby';
 
 type Paths = ts.CompilerOptions['paths'];
 
 type Principal = { principal: ProjectPrincipal; cwds: Set<string>; pathKeys: Set<string>; pkgNames: Set<string> };
 type Principals = Set<Principal>;
 
-type Options = {
+export type PrincipalOptions = {
   cwd: string;
   compilerOptions: ts.CompilerOptions;
   paths: Paths;
   compilers: [SyncCompilers, AsyncCompilers];
   pkgName: string;
+  isGitIgnored: GlobbyFilterFunction;
 };
 
 const mergePaths = (cwd: string, compilerOptions: ts.CompilerOptions, paths: Paths = {}) => {
@@ -33,7 +35,7 @@ const mergePaths = (cwd: string, compilerOptions: ts.CompilerOptions, paths: Pat
 export class PrincipalFactory {
   principals: Principals = new Set();
 
-  public getPrincipal(options: Options) {
+  public getPrincipal(options: PrincipalOptions) {
     const { cwd, compilerOptions, paths, pkgName } = options;
     options.compilerOptions = mergePaths(cwd, compilerOptions, paths);
     const principal = this.findReusablePrincipal(compilerOptions);
@@ -69,7 +71,7 @@ export class PrincipalFactory {
     principal.pkgNames.add(pkgName);
   }
 
-  private addNewPrincipal(options: Options) {
+  private addNewPrincipal(options: PrincipalOptions) {
     const { cwd, compilerOptions, pkgName } = options;
     const pathKeys = new Set(Object.keys(compilerOptions?.paths ?? {}));
     const principal = new ProjectPrincipal(options);

src/ProjectPrincipal.ts

@@ -1,4 +1,3 @@
-import { isGitIgnoredSync } from 'globby';
 import ts from 'typescript';
 import { DEFAULT_EXTENSIONS } from './constants.js';
 import { IGNORED_FILE_EXTENSIONS } from './constants.js';
@@ -10,14 +9,10 @@ import { SourceFileManager } from './typescript/SourceFileManager.js';
 import { isMaybePackageName, sanitizeSpecifier } from './util/modules.js';
 import { dirname, extname, isInNodeModules, join } from './util/path.js';
 import { timerify } from './util/Performance.js';
+import type { PrincipalOptions } from './PrincipalFactory.js';
 import type { SyncCompilers, AsyncCompilers } from './types/compilers.js';
 import type { ExportItem, ExportItemMember } from './types/exports.js';
-
-type ProjectPrincipalOptions = {
-  compilerOptions: ts.CompilerOptions;
-  cwd: string;
-  compilers: [SyncCompilers, AsyncCompilers];
-};
+import type { GlobbyFilterFunction } from 'globby';
 
 // These compiler options override local options
 const baseCompilerOptions = {
@@ -54,7 +49,7 @@ export class ProjectPrincipal {
   // We don't want to report unused exports of config/plugin entry files
   skipExportsAnalysis: Set<string> = new Set();
 
-  isGitIgnored: ReturnType<typeof isGitIgnoredSync>;
+  isGitIgnored: GlobbyFilterFunction;
   cwd: string;
   compilerOptions: ts.CompilerOptions;
   extensions: Set<string>;
@@ -69,11 +64,10 @@ export class ProjectPrincipal {
     program?: ts.Program;
   };
 
-  constructor({ compilerOptions, cwd, compilers }: ProjectPrincipalOptions) {
+  constructor({ compilerOptions, cwd, compilers, isGitIgnored }: PrincipalOptions) {
     this.cwd = cwd;
 
-    // Provide `cwd`, otherwise defaults to process.cwd() w/ incompatible slashes in Windows
-    this.isGitIgnored = isGitIgnoredSync({ cwd });
+    this.isGitIgnored = isGitIgnored;
 
     this.compilerOptions = {
       ...compilerOptions,

src/index.ts

@@ -1,3 +1,4 @@
+import { isGitIgnoredSync } from 'globby';
 import micromatch from 'micromatch';
 import { _getDependenciesFromScripts } from './binaries/index.js';
 import { ConfigurationChief } from './ConfigurationChief.js';
@@ -53,6 +54,10 @@ export const main = async (unresolvedConfiguration: CommandLineOptions) => {
   const factory = new PrincipalFactory();
   const streamer = new ConsoleStreamer({ isEnabled: isShowProgress });
 
+  // Central function, to prevent `Path is not in cwd` errors from `globby`
+  // Provide `cwd`, otherwise defaults to `process.cwd()` w/ incompatible slashes in Windows
+  const isGitIgnored = gitignore ? isGitIgnoredSync({ cwd }) : () => false;
+
   streamer.cast('Reading workspace configuration(s)...');
 
   await chief.init();
@@ -133,7 +138,7 @@ export const main = async (unresolvedConfiguration: CommandLineOptions) => {
 
     const { compilerOptions, definitionPaths } = await loadTSConfig(join(dir, tsConfigFile ?? 'tsconfig.json'));
 
-    const principal = factory.getPrincipal({ cwd: dir, paths, compilerOptions, compilers, pkgName });
+    const principal = factory.getPrincipal({ cwd: dir, paths, compilerOptions, compilers, pkgName, isGitIgnored });
 
     const worker = new WorkspaceWorker({
       name,