eslint-plugin-prettier possible regression

[a-ursino]

Hi

I'm aware of #128 but noticed a similar behaviour using latest knip.

I've created a demo that uses npx create vue@latest as starting point to reproduce the issue a-ursino/vue-knip-demo#1

[webpro]

Yeah that may seem odd, but when we look at their docs: https://github.com/prettier/eslint-plugin-prettier#recommended-configuration we can see that first eslint-plugin-prettier should be installed, and then it's recommended to also install eslint-config-prettier, but with only this configuration:

{
  "extends": ["plugin:prettier/recommended"]
}

This resolves to only the eslint-plugin-prettier package, while eslint-config-prettier should be installed as well. But it's not a peer dependency, so Knip has no way to figure out what the real intention is.

That's why Knip his this horrible line in the code, leading to your observation (there's no eslint-config-prettier in sight for you):
https://github.com/webpro/knip/blob/b920ad7920c236de2800a6136ff662929003137f/src/plugins/eslint/helpers.ts#L14

So I think it's choosing between two bad options. I went for what I thought would be used most (their recommendation).

[a-ursino]

I've installed both eslint-config-prettier and eslint-plugin-prettier and added plugin:prettier/recommended in the extends in my PR https://github.com/a-ursino/vue-knip-demo/pull/1/files.
Am I missing something else?

[webpro]

Ah no my apologies, the issue is indeed with the /recommended path. I'll fix it shortly.

[webpro]

🚀 This issue has been resolved in v2.22.0. See Release 2.22.0 for release notes.

[webpro]

Thanks for the rep(r)o @a-ursino, very helpful.

[a-ursino]

Thanks for the amazing tool and quick fix.