Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@types/react-dom marked as unused, despite being requested as a peer dependency #239

Closed
alecmev opened this issue Sep 14, 2023 · 3 comments
Closed

@types/react-dom marked as unused, despite being requested as a peer dependency #239

alecmev opened this issue Sep 14, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@alecmev
Copy link

alecmev commented Sep 14, 2023 •
edited
Loading

Reproduction: https://github.com/alecmev/knip-repro-239 I thought about this for a bit, trying to figure out if it's Babylon.js' fault, but I don't think it is? They just want to pin the version, so that we don't run into any mismatch issues. I also don't think this is #220, unless there's a bug?
@alecmev alecmev added the bug Something isn't working label Sep 14, 2023
@alecmev alecmev changed the title @types/react-dom marked as an unused dependency, despite being requested as a peer dependency @types/react-dom marked as unused, despite being requested as a peer dependency Sep 14, 2023
@webpro webpro closed this as completed in ef94f5b Sep 18, 2023
@webpro
Copy link
Member

webpro commented Sep 18, 2023

🚀 This issue has been resolved in v2.25.1. See Release 2.25.1 for release notes.

@webpro
Copy link
Member

webpro commented Sep 18, 2023

Agreed :)

@alecmev
Copy link
Author

alecmev commented Sep 18, 2023

Thank you! 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@webpro @alecmev