Add binaries to JSON reporter #287
Conversation
Codex-
force-pushed
the
json_reporter_fix
branch
from
363ce3b
to
27cd3b7
Compare
|
No problem, done :) |
|
Thanks! Looking forward to see what you're building! Feel free to suggest more improvements, haven't used this output myself a lot yet. |
|
🚀 This pull request is included in v2.33.1. See Release 2.33.1 for release notes. |
|
Oh one thing that I'd love to get into the output would be the line number where relevant, my phase 2 for the action would be to use the output to annotate the sources on the pr, guessing we'd have to adapt the node position from the ts ast steps to relevant lines though |
|
Yes. The file position is easy to expose, the AST visitors already have pos. Only need to calc line + line pos from that. Will pick this up soon. Or maybe you are up to it? |
|
I don't think I'd get to it for quite a while if you'd be happy with having a look? 🙏 |
|
Of course, no worries! |
I'm currently working on a simple github action that will comment on a PR with the report outputs from the JSON report and noticed that the
binariesfield was missing in the json blob.Also noticed a small mistake in the documentation around the report keys