We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hey, thanks for this great program 馃槃
On version 2.33.3, I have found that it doesn't seem to detect unused getters and setters of a class
export class MyClass { public usedMethod() { console.log("I am used"); } public unusedMethod(): string { return "unusedMethod"; } public get unusedGetter(): string { return "unusedGetter"; } public set unusedSetter(_value: string) { console.log('unusedSetter'); } }
const c = new MyClass(); c.usedMethod();
It outputs this:
Unused exported class members (1) unusedMethod MyClass src/class.ts
I would have expected unusedSetter and unusedGetter to appear in the list.
unusedSetter
unusedGetter
Is this something knip could support?
knip
P.S. It looks like #274 is about unused methods of objects, this one is specifically about getters/setters of classes. They are similar features 馃憤
The text was updated successfully, but these errors were encountered:
This sounds like a missing feature, I'll look into it.
Sorry, something went wrong.
18b0056
Add support for class get/set accessors (resolves #297)
d027e97
馃殌 This issue has been resolved in v2.34.0. See Release 2.34.0 for release notes.
No branches or pull requests
Hey, thanks for this great program 馃槃
On version 2.33.3, I have found that it doesn't seem to detect unused getters and setters of a class
It outputs this:
I would have expected
unusedSetter
andunusedGetter
to appear in the list.Is this something
knip
could support?P.S. It looks like #274 is about unused methods of objects, this one is specifically about getters/setters of classes. They are similar features 馃憤
The text was updated successfully, but these errors were encountered: