Add astro plugin #298
Add astro plugin #298
Conversation
There was a problem hiding this comment.
Thanks for putting this together!
I happen to have built an Astro site recently, so this was the perfect case to try it out.
Just a bit of clean up would be great. I think more irrelevant HTML and CSS can be removed. If you could cut some of that away, that would be great. Either way, I'll be happy to merge this.
The issue with astro:content is a little bit tricky, but I'll have a fix ready after the merge. If you like, you can also include it in this PR and add a colon (:) to the second group of the regex on this line: https://github.com/webpro/knip/blob/6cd5a1d4e9575ff2dee60e1ca6cc47cbf7788acd/src/util/modules.ts#L63
|
Thanks for your prompt response! I've implemented all suggestions from your review, and was about to also change the test (as astro:content is no longer reported as unlisted - but test are somehow worse now 馃槄, both locally and on a fresh clone in Codespaces, so I think it's best if I wait for your input on the current state before I mess up even more - my understanding of the codebase is still fairly limited. |
|
I've added two commits for the remaining bits :) |
|
Next step (for me) is to rebase from the |
Co-Authored-By: Lars Kappert <lars@webpro.nl>
Co-Authored-By: Lars Kappert <lars@webpro.nl>
|
Many thanks for your kind help! 鉁傦笍 馃殌 |
|
馃殌 This pull request is included in v2.34.0. See Release 2.34.0 for release notes. |
Hi 馃憢,
Following up my issue #201 I implemented a plugin that I believe matches the behaviour of Astro quite closely, following the docs for exact patterns.
The only remaining issue is ignoring the
astro:contentmodule, as it is resolved at build/runtime by astro, and not a separate dependency. Happy to fix if you could just point me in the right direction.