You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think this is a bug, because these fields do appear to be being used. For example, let's consider "customTargetModDirectoryName". If we search for that string in VSCode, we see that it is being used in the getModTargetDirectoryName function in the utils.ts file. And if we look where that function is being used, we can very quickly work our way back to the "main.ts" file, which is explicitly listed in the "entry" field in the "knip.json" file.
Furthermore, there are other bugs contained in this output that do not have to do with class members, do you want me to open separate issues for those?
The text was updated successfully, but these errors were encountered:
Thanks for creating the reproduction, very clear. I looked into this today, but unfortunately it seems not straightforward to fix.
When running with knip -W packages/isaacscript-cli --production --strict the class members are not reported as unused, so the functionality itself works fine. Yet with multiple workspaces somehow the moment it tries to find references to the class members, not all files are resolved cq part of the program (so it doesn't find references). Will need to dig deeper.
And yes, please file one issue per bug. This way, we can discuss and keep track of them separately. Some take more time than others. I can close them separately when finished.
This is on knip version 2.40.1.
Steps to reproduce:
The final lines of the output are:
I think this is a bug, because these fields do appear to be being used. For example, let's consider "customTargetModDirectoryName". If we search for that string in VSCode, we see that it is being used in the
getModTargetDirectoryName
function in theutils.ts
file. And if we look where that function is being used, we can very quickly work our way back to the "main.ts" file, which is explicitly listed in the "entry" field in the "knip.json" file.Furthermore, there are other bugs contained in this output that do not have to do with class members, do you want me to open separate issues for those?
The text was updated successfully, but these errors were encountered: