Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

commitlint plugin update breaks when parserPreset isn't a string #631

Closed
RebeccaStevens opened this issue May 12, 2024 · 0 comments · Fixed by #632
Closed

commitlint plugin update breaks when parserPreset isn't a string #631

RebeccaStevens opened this issue May 12, 2024 · 0 comments · Fixed by #632
Labels
regression Something is no longer working

Comments

@RebeccaStevens
Copy link
Contributor

Bug was introduced in 5.14.0

parserPreset can be a record or a promise that returns a record.
@RebeccaStevens RebeccaStevens added the regression Something is no longer working label May 12, 2024
RebeccaStevens added a commit to RebeccaStevens/knip that referenced this issue May 12, 2024
@RebeccaStevens
fix(plugin-commitlint): handling of parserPreset when it's not a st…
f3b3ab8 
…ring

fix webpro-nl#631
RebeccaStevens added a commit to RebeccaStevens/knip that referenced this issue May 12, 2024
@RebeccaStevens
fix(plugin-commitlint): handling of parserPreset when it's not a st…
d581ae5 
…ring

fix webpro-nl#631
@RebeccaStevens RebeccaStevens mentioned this issue May 12, 2024
Merged
webpro pushed a commit that referenced this issue May 13, 2024
@RebeccaStevens
fix(plugin-commitlint): handling of parserPreset when it's not a st…
d7b2545 
…ring (#632)

* fix(plugin-commitlint): handling of `parserPreset` when it's not a string

fix #631

* test(plugin-commitlint): handling of parserPreset when it's not a string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
regression Something is no longer working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(plugin-commitlint): handling of parserPreset when it's not a string RebeccaStevens/knip
1 participant
@RebeccaStevens