Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Canonicalize non-GET URLs with native JSON values #859

Open
tw4l opened this issue Jul 26, 2023 · 1 comment · May be fixed by #893
Open

Canonicalize non-GET URLs with native JSON values #859

tw4l opened this issue Jul 26, 2023 · 1 comment · May be fixed by #893
Assignees
@tw4l

Comments

@tw4l
Copy link
Contributor

tw4l commented Jul 26, 2023

The way that pywb rewrites URLs for POST (and other non-GET) request canonicalization ends up writing Pythonic values into the URL such as True, False, and None, whereas we ideally want to have it use valid JSON values.

This is part of making POST canonicalization consistent across Webrecorder tools. Related to webrecorder/specs#141
@tw4l tw4l self-assigned this Jul 26, 2023
@tw4l tw4l mentioned this issue Jul 26, 2023
Open
@tw4l
Copy link
Contributor Author

tw4l commented Jul 26, 2023

We will also need to ensure that the fuzzy matching in pywb and wabac.js works with previously-created URLs created by pwyb, or develop a process to reindex as necessary.

@tw4l tw4l linked a pull request Apr 3, 2024 that will close this issue
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tw4l tw4l

Labels
None yet
Projects
Webrecorder Projects
Status: In Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use native JSON values in query string for POST canonicalization webrecorder/pywb
1 participant
@tw4l