Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on_error callback stops being called after first reconnection #970

Open
jeanbmar opened this issue Feb 18, 2024 · 0 comments
Open

on_error callback stops being called after first reconnection #970

jeanbmar opened this issue Feb 18, 2024 · 0 comments

Comments

@jeanbmar
Copy link

After a failure, this line will set the WebSocketApp instance in reconnecting mode forever:

https://github.com/websocket-client/websocket-client/blob/master/websocket/_app.py#L613

Indeed, setSock will only be called as reconnecting. As a result any further error will be swallowed here:

https://github.com/websocket-client/websocket-client/blob/master/websocket/_app.py#L582

I don't think we even want to swallow the reconnection-specific errors. Should the condition be completely removed?

@jeanbmar jeanbmar changed the title on_error callback stop being called after first reconnection on_error callback stops being called after first reconnection Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant