Allow all options accepted by http{,s}.request()
#1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpinca
changed the title
http{,s}.request()http{,s}.request()
lpinca
force-pushed
the
allow/all-options
branch
2 times, most recently
from
1f8f123
to
854ed0d
Compare
Do not use an agent by default and add ability to use all options allowed in `http.request()` and `https.request()`.
lpinca
force-pushed
the
allow/all-options
branch
from
854ed0d
to
15bdb5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it is only possible to use some of the tls options allowed in https.request(). This add the ability to use all of them.