Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent remix from adjusting our tsconfig #121

Closed
kof opened this issue Jul 7, 2022 · 1 comment · Fixed by #1920
Closed

Prevent remix from adjusting our tsconfig #121

kof opened this issue Jul 7, 2022 · 1 comment · Fixed by #1920
Assignees
@TrySound
Labels
area:infra Infrastructural tasks, tools complexity:low Good for newcomers, up to a few days of work prio:2 Always look for prio:1 issues first before working on prio:2 type:bug Something isn't working

Comments

@kof
Copy link
Member

kof commented Jul 7, 2022 

 Loading environment variables from .env
@webstudio-is/designer:dev: Watching Remix app in development mode...
@webstudio-is/designer:dev: The following suggested values were added to your "tsconfig.json". These values can be changed to fit your project's needs:
@webstudio-is/designer:dev:
@webstudio-is/designer:dev: 	- compilerOptions.allowJs was set to 'true'
@webstudio-is/designer:dev: 	- compilerOptions.forceConsistentCasingInFileNames was set to 'true'
@webstudio-is/designer:dev: 	- compilerOptions.lib was set to 'DOM,DOM.Iterable,ES2019'
@webstudio-is/designer:dev: 	- compilerOptions.strict was set to 'true'
@webstudio-is/designer:dev: 	- compilerOptions.target was set to 'ES2019'
@webstudio-is/designer:dev:
@webstudio-is/designer:dev: The following mandatory changes were made to your tsconfig.json:
@webstudio-is/designer:dev:
@webstudio-is/designer:dev: 	- compilerOptions.esModuleInterop was set to 'true'
@webstudio-is/designer:dev: 	- compilerOptions.isolatedModules was set to 'true'
@webstudio-is/designer:dev: 	- compilerOptions.jsx was set to 'react-jsx'
@webstudio-is/designer:dev: 	- compilerOptions.moduleResolution was set to 'node'
@webstudio-is/designer:dev: 	- compilerOptions.noEmit was set to 'true'
@webstudio-is/designer:dev: 	- compilerOptions.resolveJsonModule was set to 'true'
@webstudio-is/designer:dev:
@kof kof added type:enhancement New feature or request complexity:medium Up to 1 week of work area:infra Infrastructural tasks, tools labels Jul 7, 2022
@kof
Copy link
Member Author

kof commented Jul 7, 2022

dividab/tsconfig-paths#209 (comment)

@kof kof added type:bug Something isn't working complexity:low Good for newcomers, up to a few days of work prio:2 Always look for prio:1 issues first before working on prio:2 and removed type:enhancement New feature or request complexity:medium Up to 1 week of work labels Jul 7, 2022
@kof kof unassigned okonet Nov 4, 2022
TrySound added a commit that referenced this issue Jul 10, 2023
@TrySound
Extend tsconfig from package in remix apps
c16ae1e 
Closes #121

Looks like since upgrade to remix 1.18 tsconfig is not longer updated
and we finally can access reusable config by package name.
@TrySound TrySound mentioned this issue Jul 10, 2023
Merged
8 tasks
@TrySound TrySound self-assigned this Jul 10, 2023
TrySound added a commit that referenced this issue Jul 10, 2023
@TrySound
Extend tsconfig from package in remix apps (#1920)
db31e37 
Closes #121

Looks like since upgrade to remix 1.18 tsconfig is not longer updated
and we finally can access reusable config by package name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TrySound TrySound

Labels
area:infra Infrastructural tasks, tools complexity:low Good for newcomers, up to a few days of work prio:2 Always look for prio:1 issues first before working on prio:2 type:bug Something isn't working
Projects
No open projects
Postponed
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Extend tsconfig from package in remix apps webstudio-is/webstudio
3 participants
@okonet @kof @TrySound