Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Enable text-wrap balance and a few more new properties #3166

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

feat: Enable text-wrap balance and a few more new properties #3166

wants to merge 12 commits into from

Conversation

kof
Copy link
Member

@kof kof commented Apr 14, 2024 •
edited

Closes #3162

Description

  • updated mdn data - it now has a bunch of new properties

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env.example and the builder/env-check.js if mandatory

@kof kof requested a review from istarkov April 14, 2024 09:41
@TrySound
Copy link
Member

text-wrap and white-space conflicts with each other. When user set text-wrap: nowrap, white-space shows normal and lies to user.

@kof
Copy link
Member Author

kof commented Apr 15, 2024

text-wrap and white-space conflicts with each other. When user set text-wrap: nowrap, white-space shows normal and lies to user.

@TrySound any suggestion what to do about it?

@kof kof marked this pull request as draft April 16, 2024 22:58
@kof kof removed the request for review from istarkov April 16, 2024 22:58
@kof kof changed the title feat: Enable text-wrap balance and a few more new properties draft: Enable text-wrap balance and a few more new properties Apr 16, 2024
@kof kof mentioned this pull request Apr 16, 2024
Merged
7 tasks
kof added a commit that referenced this pull request Apr 17, 2024
@kof
chore: Improved descriptions prompt and descriptions (#3186)
2c24e1f 
## Description

Bringing the changes from
#3166 as a separate PR

## Steps for reproduction

1. click button
2. expect xyz

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
5de6)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env.example`
and the `builder/env-check.js` if mandatory
@kof kof changed the title draft: Enable text-wrap balance and a few more new properties feat: Enable text-wrap balance and a few more new properties Apr 17, 2024
@kof kof mentioned this pull request Apr 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable text-wrap: balance
2 participants
@kof @TrySound