fix: Remove flat util fn #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, but I think we haven't yet dropped support for Node 10, right? @jimmywarting |
|
Seems like you only test 14... create-torrent/.github/workflows/ci.yml Lines 10 to 20 in ffdce7d |
|
True. If that's what we are supporting as minimum then we should update the |
|
There is talks about switching to ESM, meaning: v12.20+ but the blocker is the testing framework that we use |
|
12 is the minimum right now. |
| announceList.push([[global.WEBTORRENT_ANNOUNCE]]) | ||
| } else if (Array.isArray(global.WEBTORRENT_ANNOUNCE)) { | ||
| announceList = announceList.concat(global.WEBTORRENT_ANNOUNCE.map(u => [u])) | ||
| if (globalThis.WEBTORRENT_ANNOUNCE) { |
There was a problem hiding this comment.
Is this backwards compatible with global through browserify?
There was a problem hiding this comment.
DiegoRBaquero
approved these changes
Aug 5, 2021
webtorrent-bot
pushed a commit
that referenced
this pull request
Aug 5, 2021
# [5.0.0](v4.7.2...v5.0.0) (2021-08-05) ### Bug Fixes * Remove flat util fn ([#136](#136)) ([de7e8a9](de7e8a9)) ### BREAKING CHANGES * Node 12+ supported
|
🎉 This PR is included in version 5.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ ] Documentation update
[ ] Bug fix
[ ] New feature
[x] Other, please explain: Fixed a Todo about removing flat
...also used the globalThis namespace instead of node's only global variable