Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPM Package doesn't install without the --ignoreos parameter #1849

Open
sbadux opened this issue Jul 22, 2020 · 3 comments
Open

RPM Package doesn't install without the --ignoreos parameter #1849

sbadux opened this issue Jul 22, 2020 · 3 comments

Comments

@sbadux
Copy link

sbadux commented Jul 22, 2020

What version of WebTorrent Desktop are you using?
webtorrent-desktop-0.23.0-1.x86_64.rpm

What operating system and version?
Fedora 32 64bit

What happened?
I downloaded the package webtorrent-desktop-0.23.0-1.x86_64.rpm then I run from the terminal
rpm -i webtorrent-desktop-0.23.0-1.x86_64.rpm
the terminal says that the package is "intended for a different operating system".
It can be installed forcing the --ignoreos option and it seems to work

What did you expect to happen?
It should install webtorrent without the --ignoreos option

Are you willing to submit a pull request to fix this bug?
I'm not a developer so I can't help :(

@sbadux sbadux changed the title RPM Package doesn't work RPM Package doesn't install without the --ignoreos parameter Jul 22, 2020
@alxhotel alxhotel added the bug label Jul 22, 2020
@hicom150
Copy link
Contributor

hicom150 commented Aug 3, 2020

Sent electron-userland/electron-installer-redhat#175 to try to fix the problem.
Let's hope that it gets approved soon 😅

@fcastilloec
Copy link

In order to properly fix this, you have to build the .rpm on a Linux machine, perhaps use GitHub actions (or Travis) to build.
Otherwise, no matter what you do, RPM will always override the OS parameter with the system you're using to build to make sure that people don't just specify any OS as the target while building on a non-compatible platform.

@hicom150
Copy link
Contributor

hicom150 commented Aug 4, 2020

I've tested that with the submitted PR we can override the OS parameter and create a valid linux targeted .rpm from macOS, but as you correctly suggested, I think in the long run it could be very interesting to migrate to GitHub Actions all the building process 👍

There is already an issue #1678 with a similar suggestion 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants