Skip to content
This repository has been archived by the owner on Sep 21, 2023. It is now read-only.

verison subcommand and bot /version command for PRs refer to nonexistent "merge commit" #110

Closed
link2xt opened this issue Jun 25, 2023 · 1 comment · Fixed by #109
Closed

verison subcommand and bot /version command for PRs refer to nonexistent "merge commit" #110

link2xt opened this issue Jun 25, 2023 · 1 comment · Fixed by #109
Assignees
@link2xt

Comments

@link2xt
Copy link
Contributor

link2xt commented Jun 25, 2023 •
edited

During the build checkout action checks out not the latest commit on the PR but a "merge commit". This is not well documented and is also confusing to other users of the actions/checkout GitHub Action: actions/checkout#426

There is a workaround documented in the README:
https://github.com/actions/checkout/blob/96f53100ba2a5449eb71d2e6604bbcd94b9449b5/README.md#Checkout-pull-request-HEAD-commit-instead-of-merge-commit

I originally noticed this in another PR, see my comment:
#108 (comment)
@link2xt link2xt self-assigned this Jun 25, 2023
@link2xt link2xt mentioned this issue Jun 25, 2023
Merged
@link2xt
Copy link
Contributor Author

link2xt commented Jun 25, 2023

Ready for review fix is at #109.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@link2xt link2xt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: checkout pull request HEAD when building preview tarballs webxdc/store
1 participant
@link2xt