Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom shields #67

Open
gilbertohasnofb opened this issue Oct 24, 2020 · 8 comments
Open

Custom shields #67

gilbertohasnofb opened this issue Oct 24, 2020 · 8 comments
Labels
discussion Open for community discussion feature-request A request for a new feature help wanted Extra attention is needed

Comments

@gilbertohasnofb
Copy link

Hi, first of all, great project, really love it and I'm already using it in my repos.

It would be great to be able to use custom shields in the project image. Currently we can only turn on/off some specific shields related to the repo (stars, issues, forks), but it would be great to be able to add custom ones. For instance, these are the shields I have in my project's README.rst file:

image

It would be wonderful if there was a way of adding these to the project image itself.

@gilbertohasnofb
Copy link
Author

Just thinking of it, they would not be clickable any longer since they would be in a single image, right?

@CryogenicPlanet CryogenicPlanet added the feature-request A request for a new feature label Oct 24, 2020
@CryogenicPlanet
Copy link
Collaborator

@gilbertohasnofb Thanks for the suggesstion

In terms of the second question, yes images won't be clickable but I could look into if github readme support like html embded or iframe, then we could serve html as an option to allow the buttons to be clickable

@wei
Copy link
Owner

wei commented Oct 26, 2020

FYI, I don't think GitHub README supports html or iframe.

@bokub
Copy link

bokub commented Dec 4, 2020

FYI, I don't think GitHub README supports html or iframe

No but it supports SVG, which can have links in it 🤷

@wei
Copy link
Owner

wei commented Dec 4, 2020

@bokub could you provide an example svg with links in it? I haven't seen it work on GitHub~

@bokub
Copy link

bokub commented Dec 4, 2020

I just tested and you're right, a click on the links just open the image in a new tab, the links can be clicked on that new tab but not in the original.

@wei
Copy link
Owner

wei commented Dec 4, 2020

@bokub yeah that's too bad~

@bokub
Copy link

bokub commented Dec 4, 2020

However, the original idea is great, being able to include custom badges exactly like you include the project logo

@wei wei added the discussion Open for community discussion label Nov 21, 2022
@CryogenicPlanet CryogenicPlanet added the help wanted Extra attention is needed label Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Open for community discussion feature-request A request for a new feature help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants