Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of the 'module-no-classes-transpile' dist build and enforce the usage of newer babel instead #131

Closed
vzaidman opened this issue Aug 4, 2020 · 0 comments
Closed

Get rid of the 'module-no-classes-transpile' dist build and enforce the usage of newer babel instead #131

vzaidman opened this issue Aug 4, 2020 · 0 comments
Labels
enhancement New feature or request
Milestone
Version 5

Comments

@vzaidman
Copy link
Collaborator

vzaidman commented Aug 4, 2020 •
edited

  • enforce using babel with the ability to extend native plugins by adding the correct version of babel to peedDeps
  • remove all mentions of this in readme and link to the corresponding issue (class constructors must be invoked with |new| #5)
  • explain the need to update babel / use older version of the library in the issue
@vzaidman vzaidman added the enhancement New feature or request label Aug 4, 2020
@vzaidman vzaidman added this to the Version 5 milestone Aug 4, 2020
vzaidman added a commit that referenced this issue Aug 15, 2020
@vzaidman
version 5 updates:
98d33b9 
* make logOwnerReasons true by default.
* only trackHooks if they are supported.
* removed building without .babel-plugin-transform-classes because babel fixed it in their newer versions. removed a mention to this from readme. this closes #5 closes #131.
* removed babel-plugin-lodash - we don't really care about the bundle size and also the user of the library might use their own lodash optimizations instead.
* we only build a "umd" version now. Since the package is only for development, we don't really care about different build types.
* improved readme in general, including the installation tips. this closes #130.
vzaidman added a commit that referenced this issue Oct 22, 2020
@vzaidman
version 5 updates:
8c7c65f 
* make logOwnerReasons true by default.
* only trackHooks if they are supported.
* removed building without .babel-plugin-transform-classes because babel fixed it in their newer versions. removed a mention to this from readme. this closes #5 closes #131.
* removed babel-plugin-lodash - we don't really care about the bundle size and also the user of the library might use their own lodash optimizations instead.
* we only build a "umd" version now. Since the package is only for development, we don't really care about different build types.
* improved readme in general, including the installation tips. this closes #130.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Version 5
Development

No branches or pull requests
1 participant
@vzaidman