Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How you deal with react-refresh? #1059

Open
amerllica opened this issue Apr 27, 2021 · 13 comments
Open

How you deal with react-refresh? #1059

amerllica opened this issue Apr 27, 2021 · 13 comments

Comments

@amerllica
Copy link
Contributor

Dear Wellyshen, In my project I updated the Webpack to the higher version, and also I used webpack-hot-server-middleware and I have server-build and everything works well, but I lost react-refresh. how you deal with the react-refresh issue?

Because it has some issues with Webpack 5.

@wellyshen
Copy link
Owner

wellyshen commented Apr 28, 2021

@amerllica Thank you for telling me about this issue, I'm facing this issue too. I will spend time investigating it, if you have a solution please share it with me.

@wellyshen
Copy link
Owner

wellyshen commented Apr 28, 2021

@amerllica Yo bro, here's the temporary workaround for this issue, see #1065

@amerllica
Copy link
Contributor Author

@wellyshen Really thanks, I will upload my changes in another repo with fork of your repo, to show you how I made it, actually my friend Saeed Padyab helped me a lot. I will review this issue, thanks bro.

@wellyshen
Copy link
Owner

@amerllica Nice thank you for that 😎

@wellyshen wellyshen reopened this Apr 29, 2021
@wellyshen
Copy link
Owner

@amerllica Will you show me the solution for the setup of react-fresh with SSR bundle?

@wellyshen wellyshen added enhancement and removed bug labels Apr 29, 2021
@amerllica
Copy link
Contributor Author

@wellyshen, My entire SSR solution is different from your implementation, I used webpack-hot-server-middleware and the react-refresh works well in it. My base configuration is on the latest version of RCS before your new SSR.

If you want I can make a SandBox or a TempRepo to show you my codes. I didn't add additional settings.

@wellyshen
Copy link
Owner

wellyshen commented May 3, 2021

@amerllica I see. Do you think it's a good choice to tweak this starter for enabling react-fresh based your configuration? By the way, I have tested Next.js, react-refresh fails too.

@amerllica
Copy link
Contributor Author

@wellyshen, I hate Next.js, really.

I think it could be a good approach to test my configuration. and then prepare yours with mine. and then choose what's better.

If you want, I should send a PR to another branch of your repo, please keep me posted, because of my tight time, it takes some days.

@wellyshen
Copy link
Owner

wellyshen commented May 3, 2021

@amerllica Lol you make me laugh bro. Can you show me your configuration first? I will take take to study it.

@amerllica
Copy link
Contributor Author

@wellyshen, it is not on GitHub, it's on BitBucket and it is private, if you want come here, I'm live now. I can show you my codes by using screen sharing.

@wellyshen
Copy link
Owner

@amerllica I won't see it now (because I'm eating). Maybe you can show me some code snippets when you have time.

@amerllica
Copy link
Contributor Author

amerllica commented May 3, 2021

@wellyshen, Showing code snippets needs preparing and it takes my time. finish your eating, take rest, whenever you want, call me on WhatsApp or come here: https://meet.google.com/isf-wcxy-bqh then I can share my screen and show you what I did.

WA: https://wa.me/qr/QUAQFKN4VSMBF1

@wellyshen
Copy link
Owner

@amerllica I will find a day to book your time for it. Thanks bro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants