Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minification not working? #78

Closed
iamacup opened this issue Jul 16, 2017 · 2 comments
Closed

Minification not working? #78

iamacup opened this issue Jul 16, 2017 · 2 comments

Comments

@iamacup
Copy link
Contributor

iamacup commented Jul 16, 2017

Hey

First - i love what you have done, and i am so thankful you made this pack! I am trying to keep our project up to date with yours, but the latest changes have left me with a question:

I think the latest version of the starter pack is missing JS minification, the last version i forked (https://github.com/iamacup/sliips-ui/tree/cbe0825aff4c22d16793babd4a3bd089f1a828db) had the following stats:

https://pastebin.com/5bQ7tmdS

vendor.c476fbf6.js 469 kB 1 [emitted] [big] vendor

But the latest version of react-cool-starter has this:

https://pastebin.com/iHYb0KN6

vendor.c5a4f66d.js 1.99 MB 1 [emitted] [big] vendor

@iamacup
Copy link
Contributor Author

iamacup commented Jul 17, 2017

May be related to this: babel/minify#172

@wellyshen
Copy link
Owner

@iamacup Thank you for the instruction. I have use another plugin to replace the original one. Now it works great :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants