Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to disable Chinese numeral output in the cli? #565

Closed
statementreply opened this issue Jan 22, 2020 · 6 comments
Closed

How to disable Chinese numeral output in the cli? #565

statementreply opened this issue Jan 22, 2020 · 6 comments
Labels
cli Issues related to commandline interface

Comments

@statementreply
Copy link
Contributor

None of the following work

  • --outputHanzi=false
  • --outputHanzi false
  • --no-outputHanzi
@LingDong-
Copy link
Member

Thanks for spotting the issue! I think commander.js does not support unsetting a defaultly true flag to false:

tj/commander.js#344
tj/commander.js#928

I think we should change the option to --no-outputHanzi and default it to false.

Also I discovered some issues with repl mode. Will fix today.

@LingDong-
Copy link
Member

LingDong- commented Jan 22, 2020

Fixed! 2d90cb7 e45f655

  • --no-outputHanzi should work correctly now (ts-node src/cli.js --no-outputHanzi), except for interactive REPL mode, where it never outputs Hanzi. Will see what I can do.

EDIT by antfu: fix commit id

@antfu
Copy link
Member

antfu commented Jan 22, 2020

@LingDong- Oh wait, the duplicated commits get back 🤣

@antfu
Copy link
Member

antfu commented Jan 22, 2020

I have reverted them. Maybe it's better for you to delete the repo and clone again. XD

@LingDong-
Copy link
Member

@antfu Oh crap, thanks for fixing it! I re-cloned. Actually I have 9 messed-up versions of this repo on my disk due to similar situations. Got to love how easy it is to work with git XD


I've now added some improvements to the REPL.

e05bf9a

  • REPL now has ability to output Hanzi, and respects --no-outputHanzi
  • Use up and down arrow keys to load previous input, like shell/any standard REPL!

@LingDong- LingDong- added the cli Issues related to commandline interface label Jan 23, 2020
@antfu
Copy link
Member

antfu commented Jan 23, 2020

I am using GitKraken FYI. It's a handy tool for manage complex projects 😉

@antfu antfu closed this as completed Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Issues related to commandline interface
Projects
None yet
Development

No branches or pull requests

3 participants