Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whatpr / PR Preview snapshots #156

Open
Tracked by #92
annevk opened this issue May 22, 2018 · 1 comment
Open
Tracked by #92

whatpr / PR Preview snapshots #156

annevk opened this issue May 22, 2018 · 1 comment

Comments

@annevk
Copy link
Member

annevk commented May 22, 2018

Once #151 lands whatpr will still contain snapshots without the necessary warnings due to https://github.com/tobie/pr-preview/blob/2bc932997ebe66aebccb0f089f11d0f9d1840281/lib/wattsi-client.js#L75-L113 and due to whatwg/wattsi#64 not being supported for multipage.

Another problem with whatpr directly invoking wattsi is that various scripts from this repository are not applied so there will be a couple of subtle differences.

We should offer a build server that does include the html-build scripts and is able to emit multipage snapshots that include warnings.

@annevk
Copy link
Member Author

annevk commented May 31, 2018

@domenic my thinking here is that I will change the <default-or-review> argument to <default-or-multi-snap-or-review> which would only build a multipage snapshot.

And then we adjust build.sh so it also supports just building this, perhaps based on some environment variable.

And then you'd add support for that on the server, e.g., at /html-multi-snap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant