Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"parse a vint" algorithm does not align with "matches the signature for WebM" algorithm #146

Open
Gallaecio opened this issue Jun 22, 2021 · 1 comment

Comments

@Gallaecio
Copy link

@akshaysharmajs is implementing the standard for Python (https://github.com/scrapy/xtractmime), and we find the webM parsing algorithm rather confusing.

Our confusion did not stem from what was reported in #93, though, but from the return value of the algorithm to parse vint. The algorithm states that 2 values are returned, but only 1 of those values is actually used by the calling algorithm. So the vint-parsing algorithm could be cut in half, and it would not only be simpler, but way more clear.

@annevk
Copy link
Member

annevk commented Jun 22, 2021

cc @padenot

@GPHemsley GPHemsley changed the title webM algorithm "parse a vint" algorithm does not align with "matches the signature for WebM" algorithm Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants