Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various issues in the "Signature for mp3 without id3" algorithm #168

Open
Wuelle opened this issue Apr 15, 2023 · 0 comments
Open

Various issues in the "Signature for mp3 without id3" algorithm #168

Wuelle opened this issue Apr 15, 2023 · 0 comments

Comments

@Wuelle
Copy link

Wuelle commented Apr 15, 2023

Link to the algorithm in question.

  • the mp3-rates table and mp2.5-rates table do not contain index = 15, but the algorithm allows for this value (index is 4 bits)
  • the sample-rate table does not define a value for index = 3. match an mp3 header contains a check that bails out if index is 3, but parse an mp3 frame does not.
  • parse_mp3_frame computes a samplerate that is never used
  • Typo: 6. Let skipped-bytes the return value of [...] -> 6. Let skipped-bytes be the return value of [...]
  • I'm not too familiar with the way this is handled in other specs but IMO expressions like sequence[s + 1] & 0x06 >> 1. should contain parenthesis, as the order of operations is not immediately obvious. (this might come down to personal preference)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants
@Wuelle and others