Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give SharedArrayBuffer a dedicated type (downstream) #1320

Open
2 of 5 tasks
annevk opened this issue Jun 14, 2023 · 2 comments
Open
2 of 5 tasks

Give SharedArrayBuffer a dedicated type (downstream) #1320

annevk opened this issue Jun 14, 2023 · 2 comments

Comments

@annevk
Copy link
Member

annevk commented Jun 14, 2023 •
edited

I wanted to create a tracking issue corresponding to PR #1311 as the issues it resolves aren't directly about that and it would be good to have a central place to coordinate all the downstream work.

Everything under [AllowShared] in https://dontcallmedom.github.io/webidlpedia/extended-attributes.html is impacted:

I'm pretty sure that's it, but if people think there might be more let me know.
@bathos
Copy link
Contributor

bathos commented Jun 15, 2023 •
edited

I think this change may incidentally fix some of the not-quite-right usages of “ArrayBuffer” (pointing at the Web IDL def) in WebCrypto.

[Edit: nm, still kinda busted there, but for unrelated reasons — will open an issue.]

annevk added a commit that referenced this issue Jun 15, 2023
@annevk
Give SharedArrayBuffer a dedicated type
c45a0f3 
Generally IDL objects have been 1:1 with ECMAScript objects, except for
SharedArrayBuffer. That was instead represented as
[AllowShared] ArrayBuffer, although that includes ArrayBuffer as well.
This created a number of challenges, e.g., how to return a
SharedArrayBuffer object.

So we make these changes here that will also require corresponding
downstream fixes:

* SharedArrayBuffer is now its own type.
* [AllowShared] only applies to buffer view types.
* AllowSharedBufferSource takes over from [AllowShared] BufferSource.

Downstream is tracked by #1320.

Fixes #865 and fixes #961.
@annevk annevk changed the title Give SharedArrayBuffer a dedicated type Give SharedArrayBuffer a dedicated type (downstream) Jun 15, 2023
@annevk
Copy link
Member Author

annevk commented Jun 16, 2023

I've done everything I can at this point. At least that I know about. I'll leave this open for a bit to see if there's any other fallout and maybe wait for all downstream PRs to have landed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@annevk @bathos and others